Skip to content

boards/common/arduino due: model kconfig#17240

Merged
MrKevinWeiss merged 2 commits intoRIOT-OS:masterfrom
leandrolanzieri:pr/boards/common/arduino-due/model_kconfig
Nov 23, 2021
Merged

boards/common/arduino due: model kconfig#17240
MrKevinWeiss merged 2 commits intoRIOT-OS:masterfrom
leandrolanzieri:pr/boards/common/arduino-due/model_kconfig

Conversation

@leandrolanzieri
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri commented Nov 19, 2021

Contribution description

sam3 does not seem to need extra modelling, so this just adds does it for the arduino-due common group. Build currently limited in 3cade20

Testing procedure

  • Green CI, and consistent module lists between Makefile and Kconfig.

Issues/PRs references

Part of #16875

@leandrolanzieri leandrolanzieri added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Nov 19, 2021
@leandrolanzieri leandrolanzieri added this to the Release 2022.01 milestone Nov 19, 2021
@github-actions github-actions bot added Area: boards Area: Board ports Area: CI Area: Continuous Integration of RIOT components Area: Kconfig Area: Kconfig integration labels Nov 19, 2021
@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 19, 2021
@leandrolanzieri leandrolanzieri mentioned this pull request Nov 19, 2021
Closed
@MrKevinWeiss
Copy link
Copy Markdown
Contributor

MrKevinWeiss commented Nov 23, 2021

Should be simple, rebase and rerun when you have time

@leandrolanzieri leandrolanzieri force-pushed the pr/boards/common/arduino-due/model_kconfig branch from 3cade20 to f865a0a Compare November 23, 2021 10:06
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Nov 23, 2021

Should be simple, rebase and rerun when you have time

Done

@MrKevinWeiss
Copy link
Copy Markdown
Contributor

MrKevinWeiss commented Nov 23, 2021

Please squash and maybe remove the udoo board as it doesn't look like testing it will bring so much value compared to only testing the arduino-due

@leandrolanzieri leandrolanzieri force-pushed the pr/boards/common/arduino-due/model_kconfig branch from f865a0a to b279a7b Compare November 23, 2021 10:55
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Nov 23, 2021

Please squash and maybe remove the udoo board as it doesn't look like testing it will bring so much value compared to only testing the arduino-due

Done, I also removed the CI limit

MrKevinWeiss
MrKevinWeiss approved these changes Nov 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@MrKevinWeiss MrKevinWeiss merged commit 0ddbe04 into RIOT-OS:master Nov 23, 2021
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Nov 23, 2021

Thanks for reviewing!

@leandrolanzieri leandrolanzieri deleted the pr/boards/common/arduino-due/model_kconfig branch November 23, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrKevinWeiss MrKevinWeiss MrKevinWeiss approved these changes

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

Assignees

No one assigned

Labels

Area: boards Area: Board ports Area: CI Area: Continuous Integration of RIOT components Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer

Projects

None yet

Milestone

Release 2022.01

Development

Successfully merging this pull request may close these issues.

2 participants

@leandrolanzieri @MrKevinWeiss