Skip to content

cpu/lpc1768: model kconfig#17238

Merged
MrKevinWeiss merged 3 commits intoRIOT-OS:masterfrom
leandrolanzieri:pr/cpu/lpc1768/model_kconfig
Nov 22, 2021
Merged

cpu/lpc1768: model kconfig#17238
MrKevinWeiss merged 3 commits intoRIOT-OS:masterfrom
leandrolanzieri:pr/cpu/lpc1768/model_kconfig

Conversation

@leandrolanzieri
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri commented Nov 19, 2021 •
edited
Loading

Contribution description

This adds the default Kconfig configurations for lpc1768 and hardware features to its boards:

  • mbed_lpc1768
  • seeduino_arch-pro

Note that currently CI tests are limited by c351209 to only run these two boards.

Testing procedure

  • Green CI
  • Check the modelling and compare make info-modules list with and without TEST_KCONFIG=1, they should match.

Issues/PRs references

Part of #16875

@leandrolanzieri leandrolanzieri added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Nov 19, 2021
@leandrolanzieri leandrolanzieri added this to the Release 2022.01 milestone Nov 19, 2021
@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 19, 2021
@github-actions github-actions bot added Area: boards Area: Board ports Area: CI Area: Continuous Integration of RIOT components Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Nov 19, 2021
@leandrolanzieri leandrolanzieri mentioned this pull request Nov 19, 2021
Closed
@leandrolanzieri leandrolanzieri force-pushed the pr/cpu/lpc1768/model_kconfig branch from c351209 to 7eaa15c Compare November 22, 2021 08:05
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Nov 22, 2021

I removed the limiting commit.

@MrKevinWeiss
Copy link
Copy Markdown
Contributor

MrKevinWeiss commented Nov 22, 2021

LETS GOOOOOO!!!!

@MrKevinWeiss MrKevinWeiss merged commit 4ffeb65 into RIOT-OS:master Nov 22, 2021
@leandrolanzieri leandrolanzieri deleted the pr/cpu/lpc1768/model_kconfig branch November 22, 2021 10:05
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Nov 22, 2021

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benpicco benpicco benpicco approved these changes

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

Assignees

No one assigned

Labels

Area: boards Area: Board ports Area: CI Area: Continuous Integration of RIOT components Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Platform: ARM Platform: This PR/issue effects ARM-based platforms

Projects

None yet

Milestone

Release 2022.01

Development

Successfully merging this pull request may close these issues.

3 participants

@leandrolanzieri @MrKevinWeiss @benpicco