Skip to content

cpu/kinetis: model kconfig#17235

Merged
fjmolinas merged 14 commits intoRIOT-OS:masterfrom
leandrolanzieri:cpu/kinetis/model_kconfig
Dec 9, 2021
Merged

cpu/kinetis: model kconfig#17235
fjmolinas merged 14 commits intoRIOT-OS:masterfrom
leandrolanzieri:cpu/kinetis/model_kconfig

Conversation

@leandrolanzieri
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri commented Nov 19, 2021 •
edited
Loading

Contribution description

This models the Kconfig modules for all boards based on kinetis. 72e7f8d limits the CI to test only this on mulle for now. Some changes on drivers are also included here (mostly adding hardware features to indicate presence).

The list of enabled boards is:

  • frdm-k22f
  • frdm-k64f
  • frdm-kl43z
  • frdm-kw41z
  • mulle
  • openlabs-kw41z-mini
  • openlabs-kw41z-mini-256kib
  • pba-d-01-kw2x
  • phynode-kw41z
  • teensy31
  • usb-kw41z

Testing procedure

  • Green CI
  • Check the modelling and compare make info-modules list with and without TEST_KCONFIG=1, they should match.
  • Double-check that all boards based on kinetis are here

Issues/PRs references

Part of #16875
Depends on #17307

@leandrolanzieri leandrolanzieri added this to the Release 2022.01 milestone Nov 19, 2021
@github-actions github-actions bot added Area: boards Area: Board ports Area: build system Area: Build system Area: CI Area: Continuous Integration of RIOT components Area: cpu Area: CPU/MCU ports Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: sys Area: System Platform: ARM Platform: This PR/issue effects ARM-based platforms Platform: native Platform: This PR/issue effects the native platform labels Nov 19, 2021
@leandrolanzieri leandrolanzieri mentioned this pull request Nov 19, 2021
Closed
@leandrolanzieri leandrolanzieri force-pushed the cpu/kinetis/model_kconfig branch from 72e7f8d to d0fa3d3 Compare November 23, 2021 08:33
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Nov 23, 2021

Rebased to resolve conflicts

@MrKevinWeiss
Copy link
Copy Markdown
Contributor

MrKevinWeiss commented Nov 29, 2021

Ugg, rebase and maybe we can rerun to check the output...

@leandrolanzieri leandrolanzieri force-pushed the cpu/kinetis/model_kconfig branch from d0fa3d3 to 0f5916d Compare November 29, 2021 09:55
@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 29, 2021
@leandrolanzieri leandrolanzieri mentioned this pull request Dec 1, 2021
Merged
@leandrolanzieri leandrolanzieri added the State: waiting for other PR State: The PR requires another PR to be merged first label Dec 1, 2021
@leandrolanzieri leandrolanzieri force-pushed the cpu/kinetis/model_kconfig branch from 0f5916d to 6d96862 Compare December 2, 2021 08:42
@leandrolanzieri leandrolanzieri removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 2, 2021
@leandrolanzieri leandrolanzieri force-pushed the cpu/kinetis/model_kconfig branch from 6d96862 to 28c053f Compare December 2, 2021 13:57
@leandrolanzieri leandrolanzieri removed the State: waiting for other PR State: The PR requires another PR to be merged first label Dec 2, 2021
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Dec 2, 2021

#17307 is in, I rebased. Let's see what Murdock thinks

@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Dec 3, 2021

It looks this is passing for all kinetis boards now

@leandrolanzieri leandrolanzieri force-pushed the cpu/kinetis/model_kconfig branch from 1a0a36b to 95d7511 Compare December 6, 2021 09:26
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Dec 6, 2021

I rebased to resolve conflicts.

@github-actions github-actions bot removed the Platform: native Platform: This PR/issue effects the native platform label Dec 6, 2021
MrKevinWeiss
MrKevinWeiss reviewed Dec 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick look over it looks good, let's wait for murdock I guess.

boards/phynode-kw41z/Kconfig
select BOARD_COMMON_KW41Z
select HAS_PERIPH_I2C
select HAS_PERIPH_SPI
select HAVE_CCS811
Copy link
Copy Markdown
Contributor

@MrKevinWeiss MrKevinWeiss Dec 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a big deal but is seems there is a convention to have a newline to separate HAS_ and HAVE_

Copy link
Copy Markdown
Contributor

@MrKevinWeiss MrKevinWeiss Dec 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, wanted to delete this one... It is super minor.

Copy link
Copy Markdown
Contributor Author

@leandrolanzieri leandrolanzieri Dec 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I fixed this.

@MrKevinWeiss
Copy link
Copy Markdown
Contributor

MrKevinWeiss commented Dec 6, 2021

Double-check that all boards based on kinetis are here

It also looks like all the boards are included

@MrKevinWeiss
Copy link
Copy Markdown
Contributor

MrKevinWeiss commented Dec 7, 2021

Please change the .,murdock file and squash!

@leandrolanzieri leandrolanzieri force-pushed the cpu/kinetis/model_kconfig branch 2 times, most recently from f076c4a to 46765ca Compare December 7, 2021 10:30
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Dec 7, 2021

Please change the .,murdock file and squash!

Done!

@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Dec 7, 2021

All green here

@fjmolinas
Copy link
Copy Markdown
Contributor

fjmolinas commented Dec 9, 2021

Is this waiting for anything @MrKevinWeiss ?

MrKevinWeiss
MrKevinWeiss approved these changes Dec 9, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK!

@fjmolinas fjmolinas merged commit 7362074 into RIOT-OS:master Dec 9, 2021
@leandrolanzieri leandrolanzieri deleted the cpu/kinetis/model_kconfig branch December 9, 2021 13:52
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Dec 9, 2021

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrKevinWeiss MrKevinWeiss MrKevinWeiss approved these changes

@jnohlgard jnohlgard Awaiting requested review from jnohlgard

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees

No one assigned

Labels

Area: boards Area: Board ports Area: build system Area: Build system Area: CI Area: Continuous Integration of RIOT components Area: cpu Area: CPU/MCU ports Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms

Projects

None yet

Milestone

Release 2022.01

Development

Successfully merging this pull request may close these issues.

3 participants

@leandrolanzieri @MrKevinWeiss @fjmolinas