Skip to content

drivers: import PIR motion sensor driver#1714

Merged
LudwigKnuepfer merged 1 commit intoRIOT-OS:masterfrom
LudwigKnuepfer:add_driver_pir
Sep 26, 2014
Merged

drivers: import PIR motion sensor driver#1714
LudwigKnuepfer merged 1 commit intoRIOT-OS:masterfrom
LudwigKnuepfer:add_driver_pir

Conversation

@LudwigKnuepfer
Copy link
Copy Markdown
Member

@LudwigKnuepfer LudwigKnuepfer commented Sep 25, 2014

TODO:
- [x] blacklist boards without GPIO

  • make private API static
  • remove Hauke style incompatibility catching
  • lookup sensible default pins for boards

@LudwigKnuepfer LudwigKnuepfer added the Type: new feature The issue requests / The PR implemements a new feature for RIOT label Sep 25, 2014
@LudwigKnuepfer
Copy link
Copy Markdown
Member Author

LudwigKnuepfer commented Sep 25, 2014

Bug found on the go: arduino-due hard-faults in the interrupt driven mode of this test.

@LudwigKnuepfer LudwigKnuepfer added the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Sep 25, 2014
@LudwigKnuepfer LudwigKnuepfer changed the title drivers: import PIR motion sensor driver WIP: drivers: import PIR motion sensor driver Sep 25, 2014
Kijewski
Kijewski reviewed Sep 25, 2014
View reviewed changes
drivers/pir/pir.c Outdated
Copy link
Copy Markdown
Contributor

@Kijewski Kijewski Sep 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internal but not static?

LudwigKnuepfer pushed a commit to LudwigKnuepfer/RIOT that referenced this pull request Sep 25, 2014
SQUASHME: remove missing GPIO workaround
df37c98 
Addresses RIOT-OS#1714 (comment)
LudwigKnuepfer pushed a commit to LudwigKnuepfer/RIOT that referenced this pull request Sep 25, 2014
SQUASHME: make private API static
ffdcb9d 
Addresses RIOT-OS#1714 (comment)
@LudwigKnuepfer LudwigKnuepfer added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Sep 26, 2014
LudwigKnuepfer pushed a commit to LudwigKnuepfer/RIOT that referenced this pull request Sep 26, 2014
SQUASHME: remove missing GPIO workaround
2cb5976 
Addresses RIOT-OS#1714 (comment)
LudwigKnuepfer pushed a commit to LudwigKnuepfer/RIOT that referenced this pull request Sep 26, 2014
SQUASHME: make private API static
3b9c60f 
Addresses RIOT-OS#1714 (comment)
LudwigKnuepfer pushed a commit to LudwigKnuepfer/RIOT that referenced this pull request Sep 26, 2014
SQUASHME: remove missing GPIO workaround
19a404b 
Addresses RIOT-OS#1714 (comment)
LudwigKnuepfer pushed a commit to LudwigKnuepfer/RIOT that referenced this pull request Sep 26, 2014
SQUASHME: make private API static
199c820 
Addresses RIOT-OS#1714 (comment)
@LudwigKnuepfer LudwigKnuepfer mentioned this pull request Sep 26, 2014
Merged
@LudwigKnuepfer LudwigKnuepfer removed the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Sep 26, 2014
@LudwigKnuepfer LudwigKnuepfer changed the title WIP: drivers: import PIR motion sensor driver drivers: import PIR motion sensor driver Sep 26, 2014
haukepetersen
haukepetersen reviewed Sep 26, 2014
View reviewed changes
drivers/include/pir.h Outdated
Copy link
Copy Markdown
Contributor

@haukepetersen haukepetersen Sep 26, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indention

drivers: import PIR motion sensor driver
e75dd40 
Includes an application for manual testing.
@haukepetersen
Copy link
Copy Markdown
Contributor

haukepetersen commented Sep 26, 2014

Looking great, nice effort for the documentation!

ACK (when squashed)

@LudwigKnuepfer
Copy link
Copy Markdown
Member Author

LudwigKnuepfer commented Sep 26, 2014

squashed

@LudwigKnuepfer LudwigKnuepfer removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Sep 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@haukepetersen haukepetersen

Labels

Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LudwigKnuepfer @haukepetersen @Kijewski