Skip to content

tools/zep_dispatch: forward based on source addr, not MAC addr#16957

Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom
benpicco:tools/zep_dispatch-ack_fix
Oct 26, 2021
Merged

tools/zep_dispatch: forward based on source addr, not MAC addr#16957
benpicco merged 1 commit intoRIOT-OS:masterfrom
benpicco:tools/zep_dispatch-ack_fix

Conversation

@benpicco
Copy link
Copy Markdown
Contributor

@benpicco benpicco commented Oct 6, 2021

Contribution description

Forward data soly based on the real source IPv6 address, not the virtual MAC address.
ACK frames don't have a MAC address and should still be forwarded to all nodes in range.

Testing procedure

When using advanced topologies (e.g. -t example.topo) ACK frames would never be forwarded as they don't contain a MAC addresss.

This PR fixes that.

Issues/PRs references

needed for #16932

Forward data soly based on the real source IPv6 address, not the virtual
MAC address.

ACK frames don't have a MAC address and should still be forwarded to all
nodes in range.
@benpicco benpicco added the Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) label Oct 6, 2021
@github-actions github-actions bot added the Area: tools Area: Supplementary tools label Oct 6, 2021
@benpicco benpicco requested review from jia200x and miri64 October 6, 2021 16:35
@benpicco benpicco mentioned this pull request Oct 11, 2021
2 tasks
@benpicco benpicco requested a review from fjmolinas October 14, 2021 20:13
Copy link
Copy Markdown
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ACK

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 26, 2021
@benpicco benpicco merged commit 1b09720 into RIOT-OS:master Oct 26, 2021
@benpicco benpicco deleted the tools/zep_dispatch-ack_fix branch October 26, 2021 19:07
@fjmolinas fjmolinas added this to the Release 2022.01 milestone Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants