Merged
Conversation
fjmolinas
reviewed
Sep 29, 2021
Contributor
fjmolinas
left a comment
There was a problem hiding this comment.
Thanks for this! Looks good, haven't looked at menuconfig yet..
cpu/efm32/Makefile.features
Outdated
| # Add efm32 configurations after including cortexm_common so efm32 takes precendence | ||
| # This configuration enables modules that are only available when using Kconfig | ||
| # module modelling | ||
| ifeq (1, $(TEST_KCONFIG)) |
Contributor
There was a problem hiding this comment.
Suggested change
| ifeq (1, $(TEST_KCONFIG)) | |
| ifeq (1,$(TEST_KCONFIG)) |
Comment on lines
+8
to
+9
| # include makefiles utils tools | ||
| include $(RIOTMAKE)/utils/strings.mk |
Contributor
There was a problem hiding this comment.
Isn't this available early on?
Contributor
Author
There was a problem hiding this comment.
It was returning empty string, so I'm guessing it's not.
Contributor
|
please rebase and squash @leandrolanzieri |
d989a82 to
1e3d116
Compare
1e3d116 to
a9af4cc
Compare
Contributor
|
This one needs a rebase @leandrolanzieri ! |
a9af4cc to
17e6da0
Compare
Contributor
Author
|
Done! |
fjmolinas
reviewed
Nov 2, 2021
Contributor
fjmolinas
left a comment
There was a problem hiding this comment.
ACK, will probably need another rebase for the static tests though.
17e6da0 to
6d3de2e
Compare
fjmolinas
reviewed
Nov 5, 2021
leandrolanzieri
commented
Nov 11, 2021
6d3de2e to
0d9bf24
Compare
052cf95 to
6a1340d
Compare
Contributor
Author
|
Ok this is squashed now |
Contributor
|
GO! |
Contributor
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This adds the Kconfig modules for efm32 and related boards. I added to the CI script one board with EFM32, one with EFR32 and one with EZR32.
Testing procedure
TEST_KCONFIG=1.Issues/PRs references
#16875