Skip to content

Track: ztimer replace xtimer#16903

Closed
fjmolinas wants to merge 4 commits intoRIOT-OS:masterfrom
fjmolinas:track/ztimer_replace_xtimer
Closed

Track: ztimer replace xtimer#16903
fjmolinas wants to merge 4 commits intoRIOT-OS:masterfrom
fjmolinas:track/ztimer_replace_xtimer

Conversation

@fjmolinas
Copy link
Copy Markdown
Contributor

@fjmolinas fjmolinas commented Sep 28, 2021

Contribution description

I simply ran:

$ spatch --sp-file sys/ztimer/xtimer2ztimer.cocci --macro-file-builtins dist/tools/coccinelle/include/riot-standard.h . -in_place       -include_headers

And the replaced all USEMODULE += xtimer by USEMODULE += ztimer_usec.

lets see how far away we still are...

Testing procedure

Lets see what murdock thinks...

Issues/PRs references

@github-actions github-actions bot added Area: boards Area: Board ports Area: build system Area: Build system Area: CoAP Area: Constrained Application Protocol implementations Area: core Area: RIOT kernel. Handle PRs marked with this with care! Area: cpu Area: CPU/MCU ports Area: doc Area: Documentation Area: drivers Area: Device drivers Area: examples Area: Example Applications labels Sep 28, 2021
@fjmolinas
Copy link
Copy Markdown
Contributor Author

fjmolinas commented Sep 28, 2021

Un-tagged everyone to avoid spamming..

@fjmolinas fjmolinas added CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 28, 2021
@github-actions github-actions bot removed Area: USB Area: Universal Serial Bus Area: CoAP Area: Constrained Application Protocol implementations Area: core Area: RIOT kernel. Handle PRs marked with this with care! Area: OTA Area: Over-the-air updates labels Sep 28, 2021
miri64
miri64 reviewed Sep 28, 2021
View reviewed changes
sys/include/xtimer/implementation.h Outdated
}

static inline void xtimer_set_wakeup(xtimer_t *timer, uint32_t offset, kernel_pid_t pid)
static inline void xtimer_set_wakeup(ztimer_t *timer, uint32_t offset,
Copy link
Copy Markdown
Member

@miri64 miri64 Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤨 ? Is that correct?

Copy link
Copy Markdown
Contributor Author

@fjmolinas fjmolinas Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, the script shouldn't hava run here but I thought I had fixed this...

@fjmolinas
sys/ztimer/xtimer2ztimer.cocci: extend and fix api replacements
2539ca8
@fjmolinas
treewide: replace xtimer by ztimer
e560d3a 
$ spatch --sp-file sys/ztimer/xtimer2ztimer.cocci --macro-file-builtins
dist/tools/coccinelle/include/riot-standard.h . -in_place
-include_headers
@fjmolinas
treewide: replace USEMODULE+=xtimer by USEMODULE+=ztimer_usec
da1da31
@fjmolinas fjmolinas force-pushed the track/ztimer_replace_xtimer branch from ec4bea1 to da1da31 Compare September 28, 2021 14:27
@fjmolinas
Copy link
Copy Markdown
Contributor Author

fjmolinas commented Sep 28, 2021

Ahh nice now it actually ran for a bit before hitting too many failures :D

@kaspar030
Copy link
Copy Markdown
Contributor

kaspar030 commented Sep 28, 2021

Ahh nice now it actually ran for a bit before hitting too many failures :D

hehe. for faster turn-around, may I suggest adding "BOARDS=native" to .murdock?

@aabadie aabadie mentioned this pull request Nov 2, 2021
Merged
@fjmolinas fjmolinas mentioned this pull request Nov 18, 2021
Merged
@fjmolinas fjmolinas mentioned this pull request Dec 13, 2021
Merged
@fjmolinas
Copy link
Copy Markdown
Contributor Author

fjmolinas commented Jan 25, 2022

Superseded by #17365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miri64 miri64 miri64 left review comments

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 will be requested when the pull request is marked ready for review kaspar030 is a code owner

@Teufelchen1 Teufelchen1 Awaiting requested review from Teufelchen1 Teufelchen1 will be requested when the pull request is marked ready for review Teufelchen1 is a code owner

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri will be requested when the pull request is marked ready for review leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie will be requested when the pull request is marked ready for review aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner will be requested when the pull request is marked ready for review MichelRottleuthner is a code owner

@bergzand bergzand Awaiting requested review from bergzand bergzand will be requested when the pull request is marked ready for review bergzand is a code owner

@dylad dylad Awaiting requested review from dylad dylad will be requested when the pull request is marked ready for review dylad is a code owner

@maribu maribu Awaiting requested review from maribu maribu will be requested when the pull request is marked ready for review maribu is a code owner

@basilfx basilfx Awaiting requested review from basilfx basilfx will be requested when the pull request is marked ready for review basilfx is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x will be requested when the pull request is marked ready for review jia200x is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss will be requested when the pull request is marked ready for review MrKevinWeiss is a code owner

@gschorcht gschorcht Awaiting requested review from gschorcht gschorcht will be requested when the pull request is marked ready for review gschorcht is a code owner

@jue89 jue89 Awaiting requested review from jue89 jue89 will be requested when the pull request is marked ready for review jue89 is a code owner

@benpicco benpicco Awaiting requested review from benpicco benpicco will be requested when the pull request is marked ready for review benpicco is a code owner

@AnnsAnns AnnsAnns Awaiting requested review from AnnsAnns AnnsAnns will be requested when the pull request is marked ready for review AnnsAnns is a code owner

@vincent-d vincent-d Awaiting requested review from vincent-d vincent-d will be requested when the pull request is marked ready for review vincent-d is a code owner

@keestux keestux Awaiting requested review from keestux keestux will be requested when the pull request is marked ready for review keestux is a code owner

Assignees

No one assigned

Labels

Area: boards Area: Board ports Area: build system Area: Build system Area: CI Area: Continuous Integration of RIOT components Area: CoAP Area: Constrained Application Protocol implementations Area: core Area: RIOT kernel. Handle PRs marked with this with care! Area: cpu Area: CPU/MCU ports Area: doc Area: Documentation Area: drivers Area: Device drivers Area: examples Area: Example Applications Area: network Area: Networking Area: OTA Area: Over-the-air updates Area: pkg Area: External package ports Area: sys Area: System Area: tests Area: tests and testing framework Area: timers Area: timer subsystems Area: USB Area: Universal Serial Bus CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Platform: ESP Platform: This PR/issue effects ESP-based platforms Platform: native Platform: This PR/issue effects the native platform

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fjmolinas @kaspar030 @miri64