{dev,net}/ieee802154_*: add initial Kconfig modeling#16842
{dev,net}/ieee802154_*: add initial Kconfig modeling#16842jia200x wants to merge 13 commits intoRIOT-OS:masterfrom
Conversation
|
I think this needs a rebase before review |
|
@jia200x this needs a rebase |
0625b1f to
4b09a3d
Compare
4b09a3d to
a8590f1
Compare
|
is there anything missing here? |
Yes, I have some unanswered comments, I think currently the submac test does not build |
drivers/Kconfig.net
Outdated
| select HAVE_IEEE802154_RADIO | ||
| bool |
There was a problem hiding this comment.
Minor: can you invert the order of these two lines?
| config MODULE_NETDEV_IEEE802154 | ||
| bool | ||
| help | ||
| Netdev IEEE 802.15.4 module, provides common functionalities for | ||
| netdev based IEEE 802.15.4 devices. |
There was a problem hiding this comment.
Shouldn't this and the feature better be placed in drivers/netdev?
There was a problem hiding this comment.
Things get a bit spread out. I will have to take a closer look what belongs where.
|
|
||
| menuconfig MODULE_IEEE802154 | ||
| bool "IEEE 802.15.4 support" | ||
| menuconfig FEATURE_IEEE802154 |
There was a problem hiding this comment.
I think we can just call this IEEE802154
There was a problem hiding this comment.
done, though I think we should rename the module to IEEE802154_HELPERS. A networking newbie like myself can get easily confused,,,
| menuconfig FEATURE_IEEE802154 | ||
| bool "Enable IEEE 802.15.4 support" | ||
| depends on TEST_KCONFIG | ||
| default y if HAVE_IEEE802154_RADIO && MODULE_NETDEV_DEFAULT |
There was a problem hiding this comment.
Do we want MODULE_NETDEV_DEFAULT to enable this or only the drivers? (similar to SAUL).
If we are keeping this I would suggest to hide the prompt, as it is no longer optional not to have it:
bool
prompt "IEEE 802.15.4 support" if !(HAVE_IEEE802154_RADIO && MODULE_NETDEV_DEFAULT)
| if FEATURE_IEEE802154 | ||
|
|
||
| config MODULE_IEEE802154 | ||
| bool "IEEE 802.15.4 helpers" |
There was a problem hiding this comment.
Should this default y? Moreover, does it make sense that the user disables this when they want IEEE 802.15.4 support?
| menuconfig MODULE_IEEE802154 | ||
| bool "IEEE 802.15.4 support" | ||
| menuconfig FEATURE_IEEE802154 | ||
| bool "Enable IEEE 802.15.4 support" |
There was a problem hiding this comment.
It would be nice to have some documentation as this is no minor module.
| bool "IEEE 802.15.4 security" | ||
| select MODULE_CRYPTO | ||
| select MODULE_CIPHER_MODES | ||
| depends on TEST_KCONFIG |
There was a problem hiding this comment.
It already depends on FEATURE_IEEE802154 because it's inside the if, also you can drop the dependency on TEST_KCONFIG.
| depends on FEATURE_IEEE802154 | ||
| depends on TEST_KCONFIG |
cpu/nrf52/radio/nrf802154/Kconfig
Outdated
| config HAS_RADIO_NRF802154 | ||
| bool | ||
| select HAVE_NRF5X_RADIO | ||
| select MODULE_NRF802154 if MODULE_NETDEV_DEFAULT |
There was a problem hiding this comment.
Shouldn't this also select the symbol that indicates that there is a 802.15.4 radio present?
There was a problem hiding this comment.
I think this cannot actually select the module here.
As MODULE_NRF802154 is part of a choice I added that to be the default choice. If the bluetooth stack is used then that choice can be overridden to select the BLE one first... I think.
a8590f1 to
8615a3d
Compare
|
I rebased and fixed some of the comments from @leandrolanzieri |
|
Still some issues @MrKevinWeiss (assuming you are taking over) |
|
I think @leandrolanzieri is working on a broader solution that will make this obsolete... |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions. |
|
@MrKevinWeiss this now outdated, right? Can it be closed? |
|
Yup |
Contribution description
This PR add the initial Kconfig modeling for the lower layers of IEEE 802.15.4. This includes:
netdev_ieee802154_submactests/ieee802154_submacto the list of Kconfig test executed by MurdockThis PR also refactors the IEEE 802.15.4 menu, because
MODULE_IEEE802154just provides helper functions for processing IEEE 802.15.4 frames. Last but not least, it removes unused configurations innrf802154.Testing procedure
Murdock should be enough I guess.
Issues/PRs references
Depends on #16837