drivers/mtd: fix Kconfig dependencies#16836
Merged
fjmolinas merged 2 commits intoRIOT-OS:masterfrom Sep 22, 2021
Merged
Conversation
fjmolinas
commented
Sep 13, 2021
Contributor
Author
|
@leandrolanzieri murdock is green, do you still have concerns? |
Contributor
No, I think the changes are good! Please squash |
Currently implementations of the MTD api are selecting the module, this makes it easy for default backends to be selected. But the correct modeling is simply selecting the MTD api and then selecting a backend. BOARDs providing one of the backends can expose this and then that backend can be selected by default. There is also currently nothing preventing from using the MTD api with no backend since a mock backend can easily be provided as is done in all mtd tests.
5761386 to
14ef09b
Compare
Contributor
Author
|
go! |
Contributor
Author
|
Thanks for the review @leandrolanzieri! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Currently, implementations of the MTD api are selecting the module,
this makes it easy for default backends to be selected. But the
correct modeling is simply selecting the MTD api and then selecting
a backend. BOARDs providing one of the backends can expose this and
then that backend can be selected by default.
There is also currently nothing preventing from using the MTD api
with no backend since a mock backend can easily be provided as is
done in all mtd tests.
Testing procedure
tests/mtd_rawIssues/PRs references
Split out of #16780