cpu/cortexm: ldscripts: bkup-ram -> bkup_ram#16753
Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom Aug 18, 2021
Merged
Conversation
Fixes this error with binutils 2.37: ``` /usr/lib/gcc/arm-none-eabi/11.2.0/../../../../arm-none-eabi/bin/ld:cortexm_base.ld:217: warning: memory region `bkup' not declared /usr/lib/gcc/arm-none-eabi/11.2.0/../../../../arm-none-eabi/bin/ld:cortexm_base.ld:217: syntax error ```
benpicco
approved these changes
Aug 18, 2021
Contributor
benpicco
left a comment
There was a problem hiding this comment.
The code will only use .backup.bss and .backup.data, so the section names do not matter.
This was referenced Nov 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Fixes this error with binutils 2.37 (the current one on Arch Linux):
Seems like newer binutils trip over the minus in the region name. This PR renames the memory region to "bkup_ram" (underline),
which is also more in line with the related variable names.
Testing procedure
I'm not aware of any in-tree user. With my binutils, this broke every compilation for affected boards.
IMO, successful CI should be fine!
Issues/PRs references
bkup-ramwas introduced in #11486.