pkg/wakaama: remove gnrc dependency#16563
Merged
jia200x merged 1 commit intoRIOT-OS:masterfrom Jun 22, 2021
Merged
Conversation
Contributor
|
Tested this and master, both seem to perform the same (equally flaky 😆 ) |
MrKevinWeiss
approved these changes
Jun 18, 2021
Contributor
MrKevinWeiss
left a comment
There was a problem hiding this comment.
I guess it is OK, if anyone else has anything to say now is the time.
leandrolanzieri
requested changes
Jun 18, 2021
Contributor
leandrolanzieri
left a comment
There was a problem hiding this comment.
While trying to make it work with a different stack with @jia200x we found a reference to a gnrc-implementation specific member of sock_udp_t, so it would be nice to change that as well...
Contributor
|
ping @jia200x |
61c7736 to
c8dbdd2
Compare
Member
Author
|
fixed! |
leandrolanzieri
approved these changes
Jun 22, 2021
Contributor
leandrolanzieri
left a comment
There was a problem hiding this comment.
Nice to have this finally stack independent! I tested on GNRC and the example works as expected. I understand @jia200x made it work with LWIP after implementing some netif functions that are missing for that stack.
ACK!
Member
Author
|
thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR removes the only dependency to GNRC that was present in the Wakaama example, since #12738 was already merged some time ago.
With this change it should be possible to run Wakaama with other network stacks (e.g LWIP
and soon OpenThread)Testing procedure
Run
examples/wakaamaIssues/PRs references
#12738