drivers: Add utilities for Ethernet Media-Independent Interface (MII) and use them in STM32 periph_eth#15200
Merged
benpicco merged 3 commits intoRIOT-OS:masterfrom Oct 12, 2020
Merged
Conversation
2 tasks
benpicco
previously approved these changes
Oct 11, 2020
Add utilities for working with Ethernet Media-Independent Interface for use by Ethernet drivers.
Use shared MII definitions and utilities instead own definitions.
Use shared MII register definitions from mii.h rather than own definitions.
Member
Author
|
This is now ready for review |
benpicco
approved these changes
Oct 12, 2020
Contributor
benpicco
left a comment
There was a problem hiding this comment.
Now it's clear where the values from the previous defines are coming from.
The used values do not change.
Member
Author
|
Thanks! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The Ethernet Media-Independent Interface (MII) provides a vendor-independent specification of how to interact with Ethernet PHYs. Thus, we should have those definitions in a more generic place than the STM32 specific headers.
This PR creates a utilities header similar to the
mii.hin Linux and updates the STM32 code to use it.Testing procedure
This should not change generated binaries (compared to #15193).
Issues/PRs references