Skip to content

net/sock/dtls : Expose configuration to Kconfig#14926

Merged
leandrolanzieri merged 3 commits intoRIOT-OS:masterfrom
akshaim:Kconfig_dtls
Sep 4, 2020
Merged

net/sock/dtls : Expose configuration to Kconfig#14926
leandrolanzieri merged 3 commits intoRIOT-OS:masterfrom
akshaim:Kconfig_dtls

Conversation

@akshaim
Copy link
Copy Markdown
Member

@akshaim akshaim commented Sep 2, 2020 •
edited
Loading

Contribution description

This PR exposes compile configurations in net/sock/dtls to Kconfig.

Testing procedure

  1. New documentation was built using Doxygen

    The build works fine.

  2. Test files were added to tests/gnrc_sock_dtls/

    The test branch can be found here

    Compiled binaries for native

Default State:

Firmware Output
RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

main(): This is RIOT! (Version: 2020.10-devel-1161-g37ad3-Kconfig_dtls_tests)
CONFIG_DTLS_HANDSHAKE_BUFSIZE_EXP=8
DTLS_HANDSHAKE_BUFSIZE=(1 << 8)

Usage with CFLAGS :

CFLAGS += -DCONFIG_DTLS_HANDSHAKE_BUFSIZE_EXP=10
Firmware Output
RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

main(): This is RIOT! (Version: 2020.10-devel-1161-g37ad3-Kconfig_dtls_tests)
CONFIG_DTLS_HANDSHAKE_BUFSIZE_EXP=10
DTLS_HANDSHAKE_BUFSIZE=(1 << 10)

Usage with menuconfig :

make menuconfig

Default values

RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

main(): This is RIOT! (Version: 2020.10-devel-1161-g37ad3-Kconfig_dtls_tests)
CONFIG_DTLS_HANDSHAKE_BUFSIZE_EXP=8
DTLS_HANDSHAKE_BUFSIZE=(1 << 8)
Macros Configured output
RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

main(): This is RIOT! (Version: 2020.10-devel-1161-g37ad3-Kconfig_dtls_tests)
CONFIG_DTLS_HANDSHAKE_BUFSIZE_EXP=6
DTLS_HANDSHAKE_BUFSIZE=(1 << 6)

MACROS were successfully configured.

Issues/PRs references

#12888

@leandrolanzieri leandrolanzieri added Area: Kconfig Area: Kconfig integration Area: network Area: Networking Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Sep 2, 2020
leandrolanzieri
leandrolanzieri requested changes Sep 2, 2020
View reviewed changes
@leandrolanzieri leandrolanzieri mentioned this pull request Sep 2, 2020
Open
71 tasks
leandrolanzieri
leandrolanzieri reviewed Sep 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment. Also I think that the documentation of CONFIG_DTLS_HANDSHAKE_BUFSIZE_EXP should be introduced in the same commit as the macro (836c451). So I believe it's safe to squash that and the documentation update commit into one.

@akshaim akshaim force-pushed the Kconfig_dtls branch 2 times, most recently from 6830fa9 to d2a3d14 Compare September 4, 2020 05:11
@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 4, 2020
leandrolanzieri
leandrolanzieri reviewed Sep 4, 2020
View reviewed changes
@akshaim
net/sock/dtls : Model 'DTLS_HANDSHAKE_BUFSIZE' with exponent
2cbf9de 
Introduced CONFIG_DTLS_HANDSHAKE_BUFSIZE_EXP to hold exponent and
update documentation
@akshaim
net/sock/dtls : Expose to Kconfig
b8d2d30
@akshaim
net/sock : Update documentation
55fe4a4 
Added net_sock_conf super group and updated sock_util to the super
group.
leandrolanzieri
leandrolanzieri approved these changes Sep 4, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ACK!

@leandrolanzieri leandrolanzieri added this to the Release 2020.10 milestone Sep 4, 2020
@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Sep 4, 2020
@leandrolanzieri leandrolanzieri merged commit e24a64f into RIOT-OS:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann

Assignees

No one assigned

Labels

Area: Kconfig Area: Kconfig integration Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2020.10

Development

Successfully merging this pull request may close these issues.

2 participants

@akshaim @leandrolanzieri