treewide: modify Kconfig symbol prefixes#14904
Merged
cgundogan merged 2 commits intoRIOT-OS:masterfrom Sep 1, 2020
Merged
Conversation
This changes the prefixes of the symbols generated from USEMODULE and USEPKG variables. The changes are as follow: KCONFIG_MODULE_ => KCONFIG_USEMODULE_ KCONFIG_PKG_ => KCONFIG_USEPKG_ MODULE_ => USEMODULE_ PKG_ => USEPKG_
This changes the prefix used for the symbols that reprensent modules (not the ones generated from USEMODULE). MOD_ => MODULE_
aabadie
reviewed
Sep 1, 2020
aabadie
reviewed
Sep 1, 2020
aabadie
reviewed
Sep 1, 2020
aabadie
reviewed
Sep 1, 2020
aabadie
reviewed
Sep 1, 2020
aabadie
reviewed
Sep 1, 2020
Contributor
|
I have some comments, not strictly related to this PR but I'm wondering if there aren't some issues in master. |
aabadie
approved these changes
Sep 1, 2020
Contributor
aabadie
left a comment
There was a problem hiding this comment.
Thanks for the clarifications. I couldn't find any problem so far. The new names seems more consistent to me.
ACK
Contributor
|
@cgundogan, what do you think of the new naming scheme ? |
cgundogan
approved these changes
Sep 1, 2020
Member
There was a problem hiding this comment.
@cgundogan, what do you think of the new naming scheme ?
my honest opinion? (: ..
Nevertheless, the changes look good. There are a lot of changes here .. but since most of them come from a systematic search & replace, the margin for careless slips should be rather small.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
It was proposed by @aabadie to modify the current prefix conventions for Kconfig symbols while we are in migration, to reduce possible ambiguities. After some discussion, the proposal is the following:
MODULE_USEMODULE_USEMODULEvariable. Needed only during migration.KCONFIG_MODULE_KCONFIG_USEMODULE_menuconfigs to allow optional configuration of used modules. Depend onUSEMODULE_symbols.PKG_USEPKG_USEPKGvariable. Needed only during migration.KCONFIG_PKG_KCONFIG_USEPKG_menuconfigs to allow optional configuration of used packages. Depend onUSEPKG_symbols.MOD_MODULE_PACKAGE_Testing procedure
USEMODULEandUSEPKGvariables should generate the same symbols which activate the visibility of configurations).CI.Issues/PRs references
Suggested in #14626