Skip to content

boards/native: Model features in Kconfig#14538

Merged
aabadie merged 2 commits intoRIOT-OS:masterfrom
leandrolanzieri:pr/kconfig/native_symbols
Jul 16, 2020
Merged

boards/native: Model features in Kconfig#14538
aabadie merged 2 commits intoRIOT-OS:masterfrom
leandrolanzieri:pr/kconfig/native_symbols

Conversation

@leandrolanzieri
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri commented Jul 16, 2020

Contribution description

This models the features provided by native in Kconfig.

Testing procedure

  • Check the naming and organization of the symbols
  • Green CI

Issues/PRs references

Part of #14148

@leandrolanzieri
cpu/native: Add Kconfig symbols
64970ab
@leandrolanzieri
boards/native: Add Kconfig symbols
7efe722 
Also add the board to the whitelist of tests/kconfig_features
@leandrolanzieri leandrolanzieri added the Area: Kconfig Area: Kconfig integration label Jul 16, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.10 milestone Jul 16, 2020
@cgundogan cgundogan added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 16, 2020
cgundogan
cgundogan approved these changes Jul 16, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@cgundogan cgundogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Change looks sensible. Tested on current master and then with this patch applied: It adds the correct config symbols and they can be browsed using make menuconfig.

@cgundogan cgundogan added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Jul 16, 2020
@jia200x jia200x mentioned this pull request Jul 16, 2020
Closed
@aabadie aabadie merged commit e246e7e into RIOT-OS:master Jul 16, 2020
@leandrolanzieri leandrolanzieri deleted the pr/kconfig/native_symbols branch July 16, 2020 16:10
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Jul 16, 2020

Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgundogan cgundogan cgundogan approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees

No one assigned

Labels

Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines

Projects

None yet

Milestone

Release 2020.10

Development

Successfully merging this pull request may close these issues.

3 participants

@leandrolanzieri @cgundogan @aabadie