Skip to content

stm32: model features of cpu families and boards to kconfig#14525

Merged
leandrolanzieri merged 33 commits intoRIOT-OS:masterfrom
aabadie:pr/stm32/kconfig
Jul 16, 2020
Merged

stm32: model features of cpu families and boards to kconfig#14525
leandrolanzieri merged 33 commits intoRIOT-OS:masterfrom
aabadie:pr/stm32/kconfig

Conversation

@aabadie
Copy link
Copy Markdown
Contributor

@aabadie aabadie commented Jul 15, 2020

Contribution description

This PR models all STM32 families to Kconfig and also all boards based on a STM32 CPU.

Features that are conflicting for a family or a board are not handled by this PR.

This PR also enables periph_flashpage for nucleo-f031k6 since there's no reason (according to the manual) to skip this feature on it.

There's also a small cleanup for nucleo-f410rb/nucleo-f411re that were not including the common nucleo64 features.

Testing procedure

  • A green Murdock should be OK since all boards are added to tests/kconfig_features

Issues/PRs references

Part of #14148

@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration labels Jul 15, 2020
@aabadie aabadie requested a review from leandrolanzieri July 15, 2020 15:05
@aabadie aabadie force-pushed the pr/stm32/kconfig branch 2 times, most recently from 737af73 to d922432 Compare July 15, 2020 16:25
@miri64 miri64 added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Jul 15, 2020
@aabadie aabadie force-pushed the pr/stm32/kconfig branch from cbb4994 to 83c5e6e Compare July 15, 2020 19:10
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the msbiot board is missing. Other than that some minor comments

@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Jul 16, 2020

Comments addressed and msbiot added !

@aabadie aabadie force-pushed the pr/stm32/kconfig branch from 8e52893 to c119561 Compare July 16, 2020 09:19
@leandrolanzieri leandrolanzieri added this to the Release 2020.10 milestone Jul 16, 2020
@leandrolanzieri
Copy link
Copy Markdown
Contributor

Looking good, please squash

@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines labels Jul 16, 2020
@aabadie aabadie force-pushed the pr/stm32/kconfig branch from c119561 to 4c9049e Compare July 16, 2020 09:34
@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Jul 16, 2020

Murdock is happy, just missing an ACK here @leandrolanzieri !

Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and CI is happy. ACK!

Thanks @aabadie for this contribution!

@leandrolanzieri leandrolanzieri added Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Jul 16, 2020
@leandrolanzieri leandrolanzieri merged commit f9798d9 into RIOT-OS:master Jul 16, 2020
@aabadie aabadie deleted the pr/stm32/kconfig branch August 2, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants