boards/same54-xpro: Model features in Kconfig#14483
Conversation
| config CPU_MODEL | ||
| default "same54p20a" if CPU_MODEL_SAME54P20A |
There was a problem hiding this comment.
Just noticed that now, but do we have to maintain a list of all MCUs here again?
I was quite happy that we would just have to set CPU_MODEL and the right vendor file and parameters get selected automatically just based on that.
There was a problem hiding this comment.
Well, when we switch to Kconfig CPU_MODEL will no longer be set in the Makefiles, we will be able to use the variables CONFIG_CPU_MODEL_<model> (boolean) and CONFIG_CPU_MODEL (string). This last one will be the same as CPU_MODEL currently.
|
|
||
| ## CPU common symbols | ||
| config CPU_FAM | ||
| default "samd5x" if CPU_FAM_SAMD5X |
There was a problem hiding this comment.
In #14485 you split that up into CPU_FAM_SAML10 and CPU_FAM_SAML11.
Should we have at least CPU_FAM_SAMD51 and CPU_FAM_SAME54 here?
There was a problem hiding this comment.
In #14485 I followed the existing families. If it makes sense I can do the same here, but it should also be changed in the Makefile.features.
aabadie
left a comment
There was a problem hiding this comment.
Looks good, please rebase!
b7d0bb6 to
580bd08
Compare
|
All green, GO! |
|
Thanks for reviewing ! |
|
I'm still unhappy about that CPU_MODEL ordeal as it makes dealing with external boards unnecessary cumbersome. I'm afraid there is no way around maintaining such lists, Zephyr does it too. |
For STM32, I don't see how this can be achieved automatically from vendor files, since some of them are used for multiple CPUs. The specific digit/letters at the end of the CPU model name are here to determine the number of pins, RAM len, ROM len, etc. |
Can't we do something like this and use XX there? |
|
In RIOT, the precise STM32 CPU model name is required to determine RAM/ROM len, and other things. We have to set this information somewhere. I don't know yet how it will be handled latter. For the moment, during the migration, we must stick to the way it's done with Make, so using complete CPU model names. |
Contribution description
This models the features of the
same54-xproboard, the only one that uses thesamd5xCPU so far.Testing procedure
tests/kconfig_featuresshould passIssues/PRs references
Part of #14148