Skip to content

boards/lpc1768-based: Model features in Kconfig#14470

Merged
aabadie merged 4 commits intoRIOT-OS:masterfrom
leandrolanzieri:pr/kconfig/lpc1768_boards_symbols
Jul 16, 2020
Merged

boards/lpc1768-based: Model features in Kconfig#14470
aabadie merged 4 commits intoRIOT-OS:masterfrom
leandrolanzieri:pr/kconfig/lpc1768_boards_symbols

Conversation

@leandrolanzieri
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri commented Jul 8, 2020

Contribution description

This models the features for the boards using the lpc1768 CPU:

  • mbed_lpc1768
  • seeeduino_arch-pro

Testing procedure

  • Green CI
  • tests/kconfig_features should pass for both boards

Issues/PRs references

Part of #14148

@leandrolanzieri leandrolanzieri added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: Kconfig Area: Kconfig integration labels Jul 8, 2020
@leandrolanzieri leandrolanzieri requested a review from fjmolinas July 8, 2020 17:48
@jia200x jia200x mentioned this pull request Jul 8, 2020
Closed
aabadie
aabadie approved these changes Jul 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please rebase

@leandrolanzieri leandrolanzieri force-pushed the pr/kconfig/lpc1768_boards_symbols branch from 4456366 to 7fdd3d1 Compare July 16, 2020 13:44
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Jul 16, 2020

Rebased

@leandrolanzieri leandrolanzieri added this to the Release 2020.10 milestone Jul 16, 2020
@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 16, 2020
@aabadie aabadie merged commit a20d663 into RIOT-OS:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabadie aabadie aabadie approved these changes

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees

No one assigned

Labels

Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2020.10

Development

Successfully merging this pull request may close these issues.

2 participants

@leandrolanzieri @aabadie