Skip to content

net/asymcute : Expose configurations to Kconfig#14444

Merged
leandrolanzieri merged 8 commits intoRIOT-OS:masterfrom
akshaim:Kconfig_asymcute
Jul 7, 2020
Merged

net/asymcute : Expose configurations to Kconfig#14444
leandrolanzieri merged 8 commits intoRIOT-OS:masterfrom
akshaim:Kconfig_asymcute

Conversation

@akshaim
Copy link
Copy Markdown
Member

@akshaim akshaim commented Jul 6, 2020

Contribution description

This PR exposes compile configurations in net/asymcute to Kconfig.

Testing procedure

  1. New documentation was built using Doxygen

    The build works fine.

  2. Test files were added to tests/net_asymcute/

    The test file can be found here

    Compiled binaries for native

Default State:

Firmware Output
RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

main(): This is RIOT! (Version: 2020.07-devel-1798-gba085-Kconfig_asymcute_tests)
CONFIG_ASYMCUTE_BUFSIZE_EXP=(7U)
ASYMCUTE_BUFSIZE=(1 << (7U))
CONFIG_ASYMCUTE_TOPIC_MAXLEN=(32U)
CONFIG_ASYMCUTE_KEEPALIVE=(360)
CONFIG_ASYMCUTE_KEEPALIVE_PING=(((360) / 4) * 3)
CONFIG_ASYMCUTE_T_RETRY=(10U)
CONFIG_ASYMCUTE_N_RETRY=(3U)

Usage with CFLAGS :

CFLAGS += -DCONFIG_ASYMCUTE_BUFSIZE_EXP=6
CFLAGS += -DCONFIG_ASYMCUTE_TOPIC_MAXLEN=16
CFLAGS += -DCONFIG_ASYMCUTE_KEEPALIVE=300
CFLAGS += -DCONFIG_ASYMCUTE_KEEPALIVE_PING=200
CFLAGS += -DCONFIG_ASYMCUTE_T_RETRY=11
CFLAGS += -DCONFIG_ASYMCUTE_N_RETRY=4
Firmware Output
RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

main(): This is RIOT! (Version: 2020.07-devel-1798-gba085-Kconfig_asymcute_tests)
CONFIG_ASYMCUTE_BUFSIZE_EXP=6
ASYMCUTE_BUFSIZE=(1 << 6)
CONFIG_ASYMCUTE_TOPIC_MAXLEN=16
CONFIG_ASYMCUTE_KEEPALIVE=300
CONFIG_ASYMCUTE_KEEPALIVE_PING=200
CONFIG_ASYMCUTE_T_RETRY=11
CONFIG_ASYMCUTE_N_RETRY=4

Usage with menuconfig :

make menuconfig

Default values

RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

main(): This is RIOT! (Version: 2020.07-devel-1798-gba085-Kconfig_asymcute_tests)
CONFIG_ASYMCUTE_BUFSIZE_EXP=7
ASYMCUTE_BUFSIZE=(1 << 7)
CONFIG_ASYMCUTE_TOPIC_MAXLEN=32
CONFIG_ASYMCUTE_KEEPALIVE=360
CONFIG_ASYMCUTE_KEEPALIVE_PING=((360 / 4) * 3)
CONFIG_ASYMCUTE_T_RETRY=10
CONFIG_ASYMCUTE_N_RETRY=3
Macros Configured output
RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

main(): This is RIOT! (Version: 2020.07-devel-1798-gba085-Kconfig_asymcute_tests)
CONFIG_ASYMCUTE_BUFSIZE_EXP=5
ASYMCUTE_BUFSIZE=(1 << 5)
CONFIG_ASYMCUTE_TOPIC_MAXLEN=20
CONFIG_ASYMCUTE_KEEPALIVE=300
CONFIG_ASYMCUTE_KEEPALIVE_PING=250
CONFIG_ASYMCUTE_T_RETRY=11
CONFIG_ASYMCUTE_N_RETRY=5

MACROS were successfully configured.

Issues/PRs references

#12888

@leandrolanzieri leandrolanzieri added Area: Kconfig Area: Kconfig integration Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Jul 6, 2020
@leandrolanzieri leandrolanzieri self-assigned this Jul 7, 2020
@leandrolanzieri leandrolanzieri added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Jul 7, 2020
leandrolanzieri
leandrolanzieri approved these changes Jul 7, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configuration macros are generated correctly. Documentation looks good. ACK.

@leandrolanzieri
Copy link
Copy Markdown
Contributor

leandrolanzieri commented Jul 7, 2020

@akshaim I think you need to rebase because of the new CI checks

@leandrolanzieri leandrolanzieri mentioned this pull request Jul 7, 2020
Open
71 tasks
@akshaim akshaim force-pushed the Kconfig_asymcute branch from 39bd45b to 7a2e9c8 Compare July 7, 2020 10:58
@akshaim
Copy link
Copy Markdown
Member Author

akshaim commented Jul 7, 2020

@akshaim I think you need to rebase because of the new CI checks

Done.

@leandrolanzieri leandrolanzieri merged commit fe7700c into RIOT-OS:master Jul 7, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Jul 7, 2020
@akshaim akshaim mentioned this pull request Jul 9, 2020
Closed
14 tasks
@akshaim akshaim mentioned this pull request Oct 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann

Assignees

@leandrolanzieri leandrolanzieri

Labels

Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2020.07

Development

Successfully merging this pull request may close these issues.

2 participants

@akshaim @leandrolanzieri