Skip to content

boards/nrf-based: Model features in Kconfig#14440

Merged
aabadie merged 32 commits intoRIOT-OS:masterfrom
leandrolanzieri:pr/kconfig/nrf_based_boards_symbols
Jul 16, 2020
Merged

boards/nrf-based: Model features in Kconfig#14440
aabadie merged 32 commits intoRIOT-OS:masterfrom
leandrolanzieri:pr/kconfig/nrf_based_boards_symbols

Conversation

@leandrolanzieri
Copy link
Copy Markdown
Contributor

Contribution description

This models the provided features for all nrf5x-based boards:

  • acd52832
  • adafruit-clue
  • airfy-beacon
  • arduino-nano-33-ble
  • calliope-mini
  • dwm1001
  • feather-nrf52840
  • microbit
  • nrf51dk
  • nrf51dongle
  • nrf52832-mdk
  • nrf52840-mdk
  • nrf52840dk
  • nrf52840dongle
  • nrf52dk
  • nrf6310
  • particle-argon
  • particle-boron
  • particle-xenon
  • pinetime
  • reel
  • ruuvitag
  • thingy52
  • yunjia-nrf51822

Testing procedure

  • Check the symbol organization and naming
  • tests/kconfig_features should pass for all boards

Issues/PRs references

Part of #14148

@leandrolanzieri leandrolanzieri added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: Kconfig Area: Kconfig integration labels Jul 6, 2020
@leandrolanzieri leandrolanzieri requested a review from fjmolinas July 6, 2020 06:44
@aabadie aabadie self-assigned this Jul 15, 2020
@leandrolanzieri leandrolanzieri force-pushed the pr/kconfig/nrf_based_boards_symbols branch from cd9fc79 to 4994351 Compare July 16, 2020 08:03
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

I've renamed the symbol and rebased to master to resolve the conflict in the Makefile.

@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Jul 16, 2020

please squash and let's see what Murdock has to say

@leandrolanzieri leandrolanzieri force-pushed the pr/kconfig/nrf_based_boards_symbols branch from a073758 to 204b863 Compare July 16, 2020 08:24
@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 16, 2020
Copy link
Copy Markdown
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Murdock is green which means that features exposed by Kconfig are in sync with the current Make based mechanism.

Kconfig files are correct.

ACK and go!

@aabadie aabadie merged commit f722022 into RIOT-OS:master Jul 16, 2020
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

Thanks for reviewing!

@leandrolanzieri leandrolanzieri deleted the pr/kconfig/nrf_based_boards_symbols branch July 16, 2020 09:24
@leandrolanzieri leandrolanzieri added this to the Release 2020.10 milestone Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants