Skip to content

cord_ep: allow not specify netif if only one interface exist#14403

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
pokgak:fix-cord-ep-netif
Jun 30, 2020
Merged

cord_ep: allow not specify netif if only one interface exist#14403
miri64 merged 1 commit intoRIOT-OS:masterfrom
pokgak:fix-cord-ep-netif

Conversation

@pokgak
Copy link
Copy Markdown
Contributor

@pokgak pokgak commented Jun 30, 2020

Contribution description

This PR modifies the make_sock_ep() function in cord_ep shell function to allow not specifiying the interface when using link-local address.

Testing procedure

  1. Use aiocoap-rd version 0.4b3 provided by aiocoap as RD: pip3 install --upgrade "git+https://github.com/chrysn/aiocoap@0.4b3#egg=aiocoap[all,docs]"
  2. Start the RD: aiocoap-rd
  3. From cord_ep example terminal: cord_ep register/discover [<RD ipv6 ip>]:5683

Test running cord_ep register, cord_ep discover:

  • using link-local address with and without specifiying the interface
  • using global address should also

All of it should not timeout and should register correclty for cord_ep register and return the correct registration interface for cord_ep discover.

Issues/PRs references

Fixes #14399

@pokgak pokgak requested a review from miri64 June 30, 2020 19:52
@pokgak pokgak added Area: CoAP Area: Constrained Application Protocol implementations Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 30, 2020
miri64
miri64 approved these changes Jun 30, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@miri64 miri64 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can very confidently ACK this without testing. If I'm wrong you get a cask of beer (or other beverage) from me whoever stumbles over this in case its a bug ;-P

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 30, 2020
@miri64 miri64 added this to the Release 2020.07 milestone Jun 30, 2020
@pokgak pokgak force-pushed the fix-cord-ep-netif branch from 1566fa7 to c84ace2 Compare June 30, 2020 20:27
miri64
miri64 requested changes Jun 30, 2020
View reviewed changes
@pokgak pokgak force-pushed the fix-cord-ep-netif branch from c84ace2 to edc9567 Compare June 30, 2020 20:36
miri64
miri64 approved these changes Jun 30, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-ACK

@miri64 miri64 merged commit 95fa7fb into RIOT-OS:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miri64 miri64 miri64 approved these changes

Assignees

No one assigned

Labels

Area: CoAP Area: Constrained Application Protocol implementations CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2020.07

Development

Successfully merging this pull request may close these issues.

cord_ep example timed out when registering to a resource directory

2 participants

@pokgak @miri64