Skip to content

boards/slwstk6220a: Model features provided in Kconfig#14388

Merged
PeterKietzmann merged 3 commits intoRIOT-OS:masterfrom
leandrolanzieri:pr/kconfig/ezr32wg_board_symbols
Jun 30, 2020
Merged

boards/slwstk6220a: Model features provided in Kconfig#14388
PeterKietzmann merged 3 commits intoRIOT-OS:masterfrom
leandrolanzieri:pr/kconfig/ezr32wg_board_symbols

Conversation

@leandrolanzieri
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri commented Jun 29, 2020

Contribution description

This models in Kconfig the features provided by the ezr32wg CPU and the only board that uses it so far (slwstk6220a).

Testing procedure

  • Check the symbol organization
  • The board should pass tests/kconfig_features

Issues/PRs references

Part of #14148

@leandrolanzieri leandrolanzieri added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: Kconfig Area: Kconfig integration labels Jun 29, 2020
@fjmolinas fjmolinas requested a review from basilfx June 30, 2020 15:10
PeterKietzmann
PeterKietzmann approved these changes Jun 30, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@PeterKietzmann PeterKietzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. I have manually checked Makefile.features, compared the outputs of info-features-provided and dependency-debug-features-provided-kconfig, and tests/kconfig_features reports success too:

SUCCESS: BOARD values match
SUCCESS: CPU values match
SUCCESS: CPU_MODEL values match
SUCCESS: CPU_FAM values match
SUCCESS: CPU_CORE values match
SUCCESS: CPU_ARCH values match

@PeterKietzmann PeterKietzmann added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Jun 30, 2020
@PeterKietzmann PeterKietzmann merged commit 2250c67 into RIOT-OS:master Jun 30, 2020
@leandrolanzieri leandrolanzieri deleted the pr/kconfig/ezr32wg_board_symbols branch June 30, 2020 16:30
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Jun 30, 2020

Thanks for the review!

@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Jun 30, 2020
@jia200x jia200x mentioned this pull request Jun 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeterKietzmann PeterKietzmann PeterKietzmann approved these changes

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

@basilfx basilfx Awaiting requested review from basilfx

Assignees

No one assigned

Labels

Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2020.07

Development

Successfully merging this pull request may close these issues.

2 participants

@leandrolanzieri @PeterKietzmann