cpu/esp: add feature arch_esp for all Espressif SoCs#14375
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Jun 27, 2020
Merged
cpu/esp: add feature arch_esp for all Espressif SoCs#14375benpicco merged 1 commit intoRIOT-OS:masterfrom
benpicco merged 1 commit intoRIOT-OS:masterfrom
Conversation
There are common features that can be used by ESP32 as well as ESP8266, for example the `esp_wifi` module. To be able to test for any ESP SoC, feature `arch_esp` is introduced.
benpicco
approved these changes
Jun 27, 2020
Contributor
|
There should also already be an automatic feature ‘cpu_esp8266’/‘cpu_esp32’, but given those two share a lot of code a common feature makes sense. |
Contributor
Author
|
@benpicco Thanks for reviewing and merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is a very small change which introduces feature
arch_espfor Espressif SoCs.There are features that can be used with both ESP32 and ESP8266, for example the
esp_wifimodule. In order to be able to test for any ESP SoC, the feature 'arch_esp' is introduced.With this feature it is possible to define dependencies likeTesting procedure
Use commands
and check for the
arch_espfeature.Issues/PRs references
Required for PR #12647.