Skip to content

boards/cc2538-based: Model features in Kconfig#14343

Merged
fjmolinas merged 11 commits intoRIOT-OS:masterfrom
leandrolanzieri:pr/kconfig/cc2538_based_symbols
Jun 25, 2020
Merged

boards/cc2538-based: Model features in Kconfig#14343
fjmolinas merged 11 commits intoRIOT-OS:masterfrom
leandrolanzieri:pr/kconfig/cc2538_based_symbols

Conversation

@leandrolanzieri
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri commented Jun 24, 2020

Contribution description

This PR models in Kconfig the features for all the cc2538-based boards:

  • cc2538dk
  • firefly
  • openmote-b
  • openmote-cc2538
  • remote-pa
  • remote-reva
  • remote-revb

Testing procedure

  • Check the Kconfig symbol organization
  • Green CI: tests/kconfig_features should pass for all boards

Issues/PRs references

Part of #14148

@leandrolanzieri leandrolanzieri added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: Kconfig Area: Kconfig integration labels Jun 24, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Jun 24, 2020
@jia200x jia200x mentioned this pull request Jun 24, 2020
Closed
@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 25, 2020
fjmolinas
fjmolinas approved these changes Jun 25, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Symbols organization makes sense, lets check what murdock has to say.

@fjmolinas fjmolinas merged commit c0d171a into RIOT-OS:master Jun 25, 2020
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Jun 25, 2020

Thanks for the review!

@leandrolanzieri leandrolanzieri deleted the pr/kconfig/cc2538_based_symbols branch June 25, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees

No one assigned

Labels

Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2020.07

Development

Successfully merging this pull request may close these issues.

2 participants

@leandrolanzieri @fjmolinas