boards/msp430-based: Model features in Kconfig#14340
Merged
MrKevinWeiss merged 13 commits intoRIOT-OS:masterfrom Jun 24, 2020
Merged
boards/msp430-based: Model features in Kconfig#14340MrKevinWeiss merged 13 commits intoRIOT-OS:masterfrom
MrKevinWeiss merged 13 commits intoRIOT-OS:masterfrom
Conversation
Also specify CPU_ARCH and CPU_CORE in Makefile.features.
Also specify CPU_FAM in Makefile.features
Also specify CPU_FAM in Makefile.features
MrKevinWeiss
approved these changes
Jun 24, 2020
Contributor
MrKevinWeiss
left a comment
There was a problem hiding this comment.
ACK! It seems like some msb430 features can be moved into common but that can be done at a different time. Lets see what murdock has to say!
Contributor
|
this might cause a lot of conflicts with the msp430 toolchain upgrade, is it urgent or could it possibly wait another release? |
Contributor
well, as it just adds files, it might not be too bad, so please ignore. |
Contributor
It does change some files but it is only a k-config files, so makefile should remain the same. Thanks for checking. |
Contributor
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR models the features of all msp430-based boards in Kconfig. Also, common variables (
CPU_FAM,CPU_CORE,CPU_ARCH) are defined inMakefile.features.Testing procedure
tests/kconfig_featuresshould test everythingIssues/PRs references
Part of #14148