Skip to content

cpu/fe310: boards/hifive1*: model features in Kconfig#14338

Merged
leandrolanzieri merged 3 commits intoRIOT-OS:masterfrom
aabadie:pr/cpu/fe310_kconfig
Jun 24, 2020
Merged

cpu/fe310: boards/hifive1*: model features in Kconfig#14338
leandrolanzieri merged 3 commits intoRIOT-OS:masterfrom
aabadie:pr/cpu/fe310_kconfig

Conversation

@aabadie
Copy link
Copy Markdown
Contributor

@aabadie aabadie commented Jun 23, 2020 •
edited
Loading

Contribution description

This PR is my first attempt to add some Kconfig configuration files so I tried with easy ones: the fe310 cpus and related boards.
I hope there are not too many mistakes :)

Testing procedure

  • tests/kconfig_features work for both boards:
hifive1b 
make BOARD=hifive1b -C tests/kconfig_features/ --no-print-directory 
SUCCESS: BOARD values match
SUCCESS: CPU values match
SUCCESS: CPU_MODEL values match
Building application "tests_kconfig_features" for "hifive1b" with MCU "fe310".

"make" -C /work/riot/RIOT/boards/hifive1b
"make" -C /work/riot/RIOT/core
"make" -C /work/riot/RIOT/cpu/fe310
"make" -C /work/riot/RIOT/cpu/fe310/nano
"make" -C /work/riot/RIOT/cpu/fe310/periph
"make" -C /work/riot/RIOT/cpu/fe310/vendor
"make" -C /work/riot/RIOT/drivers
"make" -C /work/riot/RIOT/drivers/periph_common
"make" -C /work/riot/RIOT/sys
"make" -C /work/riot/RIOT/sys/auto_init
"make" -C /work/riot/RIOT/sys/stdio_uart
   text	   data	    bss	    dec	    hex	filename
   8760	    104	   2408	  11272	   2c08	/work/riot/RIOT/tests/kconfig_features/bin/hifive1b/tests_kconfig_features.elf
hifive1 
make BOARD=hifive1 -C tests/kconfig_features/ --no-print-directory 
SUCCESS: BOARD values match
SUCCESS: CPU values match
SUCCESS: CPU_MODEL values match
Building application "tests_kconfig_features" for "hifive1" with MCU "fe310".

"make" -C /work/riot/RIOT/boards/hifive1
"make" -C /work/riot/RIOT/core
"make" -C /work/riot/RIOT/cpu/fe310
"make" -C /work/riot/RIOT/cpu/fe310/nano
"make" -C /work/riot/RIOT/cpu/fe310/periph
"make" -C /work/riot/RIOT/cpu/fe310/vendor
"make" -C /work/riot/RIOT/drivers
"make" -C /work/riot/RIOT/drivers/periph_common
"make" -C /work/riot/RIOT/sys
"make" -C /work/riot/RIOT/sys/auto_init
"make" -C /work/riot/RIOT/sys/stdio_uart
   text	   data	    bss	    dec	    hex	filename
   8760	    104	   2408	  11272	   2c08	/work/riot/RIOT/tests/kconfig_features/bin/hifive1/tests_kconfig_features.elf

Issues/PRs references

Ticks a couple of items in #14148

@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: Kconfig Area: Kconfig integration labels Jun 23, 2020
@jia200x jia200x mentioned this pull request Jun 23, 2020
Closed
leandrolanzieri
leandrolanzieri reviewed Jun 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Just a couple of comments.

@aabadie aabadie force-pushed the pr/cpu/fe310_kconfig branch from fe54621 to 5e71c55 Compare June 24, 2020 09:13
@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Jun 24, 2020

Thanks for the hints @leandrolanzieri. I applied the changes, directly rebased and squashed.

@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Jun 24, 2020
leandrolanzieri
leandrolanzieri approved these changes Jun 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@leandrolanzieri leandrolanzieri merged commit cd3b151 into RIOT-OS:master Jun 24, 2020
@aabadie aabadie deleted the pr/cpu/fe310_kconfig branch June 24, 2020 12:36
@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Jun 24, 2020

Thanks for reviewing and merging @leandrolanzieri !
I think now I'll have a look at STM32 CPUs if nobody is already on it.

@leandrolanzieri
Copy link
Copy Markdown
Contributor

leandrolanzieri commented Jun 24, 2020

Thanks for reviewing and merging @leandrolanzieri !
I think now I'll have a look at STM32 CPUs if nobody is already on it.

That would be really good!

@miri64 miri64 added this to the Release 2020.07 milestone Jun 24, 2020
@miri64 miri64 added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees

No one assigned

Labels

Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2020.07

Development

Successfully merging this pull request may close these issues.

3 participants

@aabadie @leandrolanzieri @miri64