pkg: tools: ensure cmake based packages/tools are built out-of-source#14286
Merged
kaspar030 merged 8 commits intoRIOT-OS:masterfrom Jun 23, 2020
Merged
pkg: tools: ensure cmake based packages/tools are built out-of-source#14286kaspar030 merged 8 commits intoRIOT-OS:masterfrom
kaspar030 merged 8 commits intoRIOT-OS:masterfrom
Conversation
This target is called by the prepare target and does nothing by default
This custom prepared target create an include directory in the build directory which is set globally in the INCLUDES variables.
f628ff5 to
f869354
Compare
Contributor
Author
|
rebased |
kaspar030
approved these changes
Jun 23, 2020
Contributor
kaspar030
left a comment
There was a problem hiding this comment.
ACK.
Tested local build of all affected packages.
PKG_SOURCE_LOCAL still works as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adapt all packages and tools that are built using CMake so that source files and generated files are not stored in the same directory. Affected packages are ccn-lite, cryptoauthlib, jerryscript and relic. Affected tool is only flatc.
The jerryscript Makefile is also reworked a bit: all cmake related target are in the main package makefile, instead of another sub-makefile.
Testing procedure
Issues/PRs references
Depends on
#14268