pkg: remove unecessary module, especially for header-only packages#14280
Merged
kaspar030 merged 3 commits intoRIOT-OS:masterfrom Jun 23, 2020
Merged
pkg: remove unecessary module, especially for header-only packages#14280kaspar030 merged 3 commits intoRIOT-OS:masterfrom
kaspar030 merged 3 commits intoRIOT-OS:masterfrom
Conversation
This package is only use for its headers so there's no module to build.
This package is only use for its headers so there's no module to build.
There's no lvgl module to build with package, only lvgl_xx modules.
72bec27 to
fd5c51f
Compare
kaspar030
reviewed
Jun 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR removes the use of empty modules (with no source built in) used with flatbuffers, gemmlowp and lvgl packages. The first two are header-only packages so there's no need to build a module. For lvgl, there's a make trick that allows to set the
MODULEname from the command and with this trick nolvglmodule is created.In the current package mechanism, a package name should become implicitly a module but here there's no concrete module with the same name. The solution is then to declare them as pseudo-modules.
Testing procedure
A green Murdock is enough (if people insist, I can provide a picture of a board running lvgl)
Issues/PRs references
None