Skip to content

pkg/wolfssl: improve build system integration#14274

Merged
leandrolanzieri merged 1 commit intoRIOT-OS:masterfrom
aabadie:pr/pkg/wolfssl_make_enh
Jun 18, 2020
Merged

pkg/wolfssl: improve build system integration#14274
leandrolanzieri merged 1 commit intoRIOT-OS:masterfrom
aabadie:pr/pkg/wolfssl_make_enh

Conversation

@aabadie
Copy link
Copy Markdown
Contributor

@aabadie aabadie commented Jun 12, 2020

Contribution description

This PR is improving the situation with the integration of the wolfssl package in the build system. The goal is mainly to avoid to alter the package sources during the build.

Testing procedure

  • A green Murdock
  • Verify wolfssl related applications are still functional and code size remains unchanged

Issues/PRs references

None

@aabadie aabadie added Area: build system Area: Build system Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 12, 2020
@aabadie aabadie force-pushed the pr/pkg/wolfssl_make_enh branch 2 times, most recently from f7e7008 to 6bce389 Compare June 12, 2020 11:09
@aabadie
pkg/wolfssl: improve build system integration
86f9190 
and avoid copying in the cloned repository when building
@aabadie aabadie force-pushed the pr/pkg/wolfssl_make_enh branch from 6bce389 to 86f9190 Compare June 12, 2020 15:49
@aabadie aabadie mentioned this pull request Jun 15, 2020
Merged
@leandrolanzieri leandrolanzieri self-assigned this Jun 18, 2020
@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 18, 2020
leandrolanzieri
leandrolanzieri approved these changes Jun 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration looks cleaner. I tested:

  • examples/dtls-wolfssl
  • tests/pkg_wolfcrypt-ed25519-verify
  • tests/pkg_wolfssl

All applications still work as expected and binary sizes on native stay the same. ACK.

@leandrolanzieri leandrolanzieri merged commit 2bdf9b1 into RIOT-OS:master Jun 18, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Jun 18, 2020
@aabadie aabadie deleted the pr/pkg/wolfssl_make_enh branch June 18, 2020 08:55
@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Jun 18, 2020

Thanks for the review and merge !

@aabadie aabadie mentioned this pull request Jun 23, 2020
Merged
@miri64 miri64 added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

Assignees

@leandrolanzieri leandrolanzieri

Labels

Area: build system Area: Build system Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2020.07

Development

Successfully merging this pull request may close these issues.

3 participants

@aabadie @leandrolanzieri @miri64