Skip to content

pkg/u8g2: improve build system integration#14272

Merged
basilfx merged 1 commit intoRIOT-OS:masterfrom
aabadie:pr/pkg/u8g2_make_enh
Jun 16, 2020
Merged

pkg/u8g2: improve build system integration#14272
basilfx merged 1 commit intoRIOT-OS:masterfrom
aabadie:pr/pkg/u8g2_make_enh

Conversation

@aabadie
Copy link
Copy Markdown
Contributor

@aabadie aabadie commented Jun 12, 2020

Contribution description

This PR reworks a bit the integration of the u8g2 package in the build system. Its goal is to avoid copying files in the cloned repository and better use RIOT modules.

Testing procedure

  • A green Murdock
  • tests/pkg_u8g2 is still working

Issues/PRs references

None

@aabadie aabadie added Area: build system Area: Build system Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 12, 2020
@aabadie aabadie requested a review from basilfx as a code owner June 12, 2020 07:17
Copy link
Copy Markdown
Member

@basilfx basilfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this with SSD1306 (I2C, SPI and console) with a STK3600.

Change does not affect the code.

@basilfx basilfx merged commit 0455bac into RIOT-OS:master Jun 16, 2020
@aabadie aabadie deleted the pr/pkg/u8g2_make_enh branch June 17, 2020 06:17
@miri64 miri64 added this to the Release 2020.07 milestone Jun 24, 2020
@miri64 miri64 added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: build system Area: Build system Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants