Skip to content

cpu/cc26x2_cc13x2: rename aux.c to restore Windows compatibility#14257

Merged
leandrolanzieri merged 1 commit intoRIOT-OS:masterfrom
benpicco:fix/14253
Jun 11, 2020
Merged

cpu/cc26x2_cc13x2: rename aux.c to restore Windows compatibility#14257
leandrolanzieri merged 1 commit intoRIOT-OS:masterfrom
benpicco:fix/14253

Conversation

@benpicco
Copy link
Copy Markdown
Contributor

@benpicco benpicco commented Jun 10, 2020 •
edited
Loading

Contribution description

AUX.* is a reserved file name on Windows. (see also)

Testing procedure

Everything should still compile, but you should be able to check out the RIOT repository on a Windows machine again (did not test this)

@jeandudey are you fine with the new name?

Issues/PRs references

fixes #14253

@benpicco benpicco added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 10, 2020
@benpicco benpicco requested a review from smlng as a code owner June 10, 2020 21:27
@benpicco benpicco requested a review from leandrolanzieri June 10, 2020 21:32
@jeandudey
Copy link
Copy Markdown
Contributor

jeandudey commented Jun 10, 2020

Yes no problem! it's fine 👍

leandrolanzieri
leandrolanzieri approved these changes Jun 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that cloning @benpicco's branch directly on a windows machine works:
git clone --single-branch --branch fix/14253 git@github.com:benpicco/RIOT.git.

ACK.

@leandrolanzieri leandrolanzieri merged commit b3a2f35 into RIOT-OS:master Jun 11, 2020
@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines labels Jun 11, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Jun 11, 2020
@benpicco benpicco deleted the fix/14253 branch June 11, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@smlng smlng Awaiting requested review from smlng

Assignees

No one assigned

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2020.07

Development

Successfully merging this pull request may close these issues.

git clone: error on Windows 10 machine, invalid file name

3 participants

@benpicco @jeandudey @leandrolanzieri