Skip to content

boards/arduino-mega2560: Model features in Kconfig#14211

Merged
PeterKietzmann merged 3 commits intoRIOT-OS:masterfrom
leandrolanzieri:pr/kconfig/atmega2560_boards_symbols
Jun 22, 2020
Merged

boards/arduino-mega2560: Model features in Kconfig#14211
PeterKietzmann merged 3 commits intoRIOT-OS:masterfrom
leandrolanzieri:pr/kconfig/atmega2560_boards_symbols

Conversation

@leandrolanzieri
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri commented Jun 5, 2020 •
edited
Loading

Contribution description

This models the features in Kconfig for the arduino-mega2560. The first 2 commits are from #14176, they are included for testing.

Testing procedure

  • tests/kconfig_features should pass for arduino-mega2560.
  • Check that the symbol organization is correct

Issues/PRs references

Depends on #14176

@leandrolanzieri leandrolanzieri added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: Kconfig Area: Kconfig integration labels Jun 5, 2020
@leandrolanzieri leandrolanzieri added the State: waiting for other PR State: The PR requires another PR to be merged first label Jun 5, 2020
@leandrolanzieri leandrolanzieri force-pushed the pr/kconfig/atmega2560_boards_symbols branch from e35a588 to 16a0452 Compare June 17, 2020 10:44
@leandrolanzieri leandrolanzieri removed the State: waiting for other PR State: The PR requires another PR to be merged first label Jun 17, 2020
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Jun 17, 2020

Rebased and adapted to new classification

@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 17, 2020
PeterKietzmann
PeterKietzmann approved these changes Jun 22, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@PeterKietzmann PeterKietzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. I have reviewed the code comparing it to #14176. Furthermore, I manually checked this boards (/cpus) Makefile.features and checked the created feature lists by Makefile and Kconfig using kconfig_features -> they match.

@PeterKietzmann PeterKietzmann added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Jun 22, 2020
@PeterKietzmann PeterKietzmann merged commit 332ae60 into RIOT-OS:master Jun 22, 2020
@leandrolanzieri leandrolanzieri deleted the pr/kconfig/atmega2560_boards_symbols branch June 22, 2020 13:06
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Jun 22, 2020

Thanks for the review!

@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Jun 22, 2020
@jia200x jia200x mentioned this pull request Jul 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeterKietzmann PeterKietzmann PeterKietzmann approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees

No one assigned

Labels

Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2020.07

Development

Successfully merging this pull request may close these issues.

2 participants

@leandrolanzieri @PeterKietzmann