Skip to content

boards/cc26xx_cc13xx-based: model features in Kconfig#14210

Merged
leandrolanzieri merged 10 commits intoRIOT-OS:masterfrom
btcven:2020_06_04-cc26xx_cc13xx_kconfig
Jun 10, 2020
Merged

boards/cc26xx_cc13xx-based: model features in Kconfig#14210
leandrolanzieri merged 10 commits intoRIOT-OS:masterfrom
btcven:2020_06_04-cc26xx_cc13xx_kconfig

Conversation

@jeandudey
Copy link
Copy Markdown
Contributor

@jeandudey jeandudey commented Jun 5, 2020

Contribution description

This adds Kconfig symbol definitions for the cc26xx_c13xx CPUs and for boards based on that CPU.

Testing procedure

  • Green CI.
  • tests/kconfig_features should pass.

Issues/PRs references

#14148

@jeandudey
cpu/cortexm_common: add HAS_CORTEX_MPU feature
fea44e8 
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
@leandrolanzieri leandrolanzieri added Area: Kconfig Area: Kconfig integration Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Jun 5, 2020
leandrolanzieri
leandrolanzieri reviewed Jun 5, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Just a minor comment regarding the organization of the symbols.

@leandrolanzieri leandrolanzieri added the Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines label Jun 5, 2020
@jia200x jia200x mentioned this pull request Jun 5, 2020
Closed
@jeandudey jeandudey force-pushed the 2020_06_04-cc26xx_cc13xx_kconfig branch from 50e460c to d12fff3 Compare June 5, 2020 13:01
leandrolanzieri
leandrolanzieri reviewed Jun 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! Looks good. Just one naming comment. Feel free to squash directly.

jeandudey added 2 commits June 8, 2020 08:23
@jeandudey
cpu/cc26xx_cc13xx: model features in Kconfig
d958051 
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
@jeandudey
cpu/cc26x2_cc13x2: model features in Kconfig
e9a2dcd 
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
@jeandudey jeandudey force-pushed the 2020_06_04-cc26xx_cc13xx_kconfig branch from b4d82be to 2dc6781 Compare June 8, 2020 13:24
@jeandudey
Copy link
Copy Markdown
Contributor Author

jeandudey commented Jun 8, 2020

All commits squashed and changes addressed. Thanks for the review!

@leandrolanzieri leandrolanzieri self-assigned this Jun 9, 2020
@leandrolanzieri leandrolanzieri added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines labels Jun 9, 2020
leandrolanzieri
leandrolanzieri reviewed Jun 9, 2020
View reviewed changes
@leandrolanzieri leandrolanzieri removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 9, 2020
jeandudey added 6 commits June 9, 2020 07:55
@jeandudey
cpu/cc26x0: model features in Kconfig
132d936 
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
@jeandudey
boards/cc1312-launcpad: model features in Kconfig
ef1fdb5 
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
@jeandudey
boards/cc1352-launchpad: model features in Kconfig
6db36b7 
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
@jeandudey
boards/cc1352p-launchpad: model features in Kconfig
eb599fd 
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
@jeandudey
boards/cc2650-launchpad: model features in Kconfig
b87efa3 
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
@jeandudey
boards/cc2650stk: model features in Kconfig
3f2be37 
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
@jeandudey
tests/kconfig_features: add cc26xx_cc13xx-based
ea931ef 
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
@jeandudey jeandudey force-pushed the 2020_06_04-cc26xx_cc13xx_kconfig branch from 2dc6781 to ea931ef Compare June 9, 2020 12:55
@leandrolanzieri leandrolanzieri added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Jun 9, 2020
leandrolanzieri
leandrolanzieri approved these changes Jun 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. There is a naming discussion going on in #14176, but this PR is in line with what currently is done in master. There may be some future naming changing, but we can make it a follow-up.

ACK.

@leandrolanzieri leandrolanzieri merged commit 58cd126 into RIOT-OS:master Jun 10, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Jun 10, 2020
@jeandudey jeandudey deleted the 2020_06_04-cc26xx_cc13xx_kconfig branch June 10, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees

@leandrolanzieri leandrolanzieri

Labels

Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2020.07

Development

Successfully merging this pull request may close these issues.

2 participants

@jeandudey @leandrolanzieri