Skip to content

boards/atmega256rfr2-based: Model features in Kconfig#14206

Merged
fjmolinas merged 5 commits intoRIOT-OS:masterfrom
leandrolanzieri:pr/kconfig/atmega256rfr2_based_boards
Jun 24, 2020
Merged

boards/atmega256rfr2-based: Model features in Kconfig#14206
fjmolinas merged 5 commits intoRIOT-OS:masterfrom
leandrolanzieri:pr/kconfig/atmega256rfr2_based_boards

Conversation

@leandrolanzieri
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri commented Jun 4, 2020 •
edited
Loading

Contribution description

This models the features in Kconfig for all the boards based on the atmega256rfr2 CPU.
The first commit is from #14176, included for testing.

Testing procedure

  • tests/kconfig_features should pass for:
    • atmega256rfr2-xpro
    • avr-rss2
    • derfmega256

Issues/PRs references

Depends on #14176

@leandrolanzieri leandrolanzieri added Type: new feature The issue requests / The PR implemements a new feature for RIOT Platform: AVR Platform: This PR/issue effects AVR-based platforms Area: Kconfig Area: Kconfig integration labels Jun 4, 2020
@jia200x jia200x mentioned this pull request Jun 4, 2020
Closed
@leandrolanzieri leandrolanzieri added the State: waiting for other PR State: The PR requires another PR to be merged first label Jun 5, 2020
@fjmolinas
Copy link
Copy Markdown
Contributor

fjmolinas commented Jun 23, 2020

This one needs a rebase @leandrolanzieri!

@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Jun 23, 2020

I'll push when #14195 is in

@leandrolanzieri leandrolanzieri force-pushed the pr/kconfig/atmega256rfr2_based_boards branch from f479e60 to c58d2ce Compare June 23, 2020 12:39
@leandrolanzieri leandrolanzieri removed the State: waiting for other PR State: The PR requires another PR to be merged first label Jun 23, 2020
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Jun 23, 2020

Rebased and adapted to the latest classification.

@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 23, 2020
fjmolinas
fjmolinas approved these changes Jun 23, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, symbols match whats currently in Makefiles

@fjmolinas fjmolinas merged commit 816d7c4 into RIOT-OS:master Jun 24, 2020
@leandrolanzieri leandrolanzieri deleted the pr/kconfig/atmega256rfr2_based_boards branch June 24, 2020 09:08
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Jun 24, 2020

Thanks for reviewing and testing!

@miri64 miri64 added this to the Release 2020.07 milestone Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees

No one assigned

Labels

Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: AVR Platform: This PR/issue effects AVR-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2020.07

Development

Successfully merging this pull request may close these issues.

3 participants

@leandrolanzieri @fjmolinas @miri64