Skip to content

kconfig: Declare common feature symbols#14151

Merged
jia200x merged 1 commit intoRIOT-OS:masterfrom
leandrolanzieri:pr/kconfig/add_cpu_board_features
May 27, 2020
Merged

kconfig: Declare common feature symbols#14151
jia200x merged 1 commit intoRIOT-OS:masterfrom
leandrolanzieri:pr/kconfig/add_cpu_board_features

Conversation

@leandrolanzieri
Copy link
Copy Markdown
Contributor

Contribution description

This PR adds the declaration of all the generic features that may be provided by boards and CPUs. The changes do not include symbols that are specific to a CPU, architecture, etc., these will be added in the specific Kconfig files.

Testing procedure

  • Read the symbols and their documentation
  • CI should detect any syntax errors in the file

Issues/PRs references

Implements partly the first point of #14148

@leandrolanzieri leandrolanzieri added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: Kconfig Area: Kconfig integration labels May 26, 2020
@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 26, 2020
@jia200x
Copy link
Copy Markdown
Member

jia200x commented May 27, 2020

doc-wise looks ok

Copy link
Copy Markdown
Member

@jia200x jia200x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. CI passes and the list of features seems to match the current features in RIOT. If for some reason we miss a feature here, it can always be added in a follow up

@jia200x jia200x merged commit 692f0ee into RIOT-OS:master May 27, 2020
@leandrolanzieri leandrolanzieri deleted the pr/kconfig/add_cpu_board_features branch May 27, 2020 09:01
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants