drivers/sps30 : Expose Configurations to Kconfig#13966
Merged
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom Apr 28, 2020
Merged
drivers/sps30 : Expose Configurations to Kconfig#13966leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom
Conversation
Contributor
leandrolanzieri
left a comment
There was a problem hiding this comment.
Looks good. Please rebase
Add CONFIG_ prefix to SPS30_ERROR_RETRY
Expose configurations to Kconfig
Member
Author
Done. |
leandrolanzieri
approved these changes
Apr 28, 2020
Contributor
leandrolanzieri
left a comment
There was a problem hiding this comment.
Straightforward. ACK.
71 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR exposes compile configurations in SPS30 Sensor Device driver to Kconfig.
Testing procedure
New macro was introduced in tests/driver_sps30/main.c for testing.
Firmware was uploaded to FIT IoT Lab test bed.
Default State:
Firmware Output
main(): This is RIOT! (Version: 2020.07-devel-200-gea488-Kconfig_sps30_tests)
CONFIG_SPS30_ERROR_RETRY=(500U)
SPS30 test application
sps30_init: [I2C_ERROR]
sps30_read_article_code: [I2C_ERROR]
sps30_read_serial_number: [I2C_ERROR]
sps30_start_fan_clean: [I2C_ERROR]
Usage with CFLAGS
/tests/driver_sps30/Makefile
Firmware Output
main(): This is RIOT! (Version: 2020.07-devel-200-gea488-Kconfig_sps30_tests)
CONFIG_SPS30_ERROR_RETRY=10
SPS30 test application
sps30_init: [I2C_ERROR]
sps30_read_article_code: [I2C_ERROR]
sps30_read_serial_number: [I2C_ERROR]
sps30_start_fan_clean: [I2C_ERROR]
Usage with Kconfig
/tests/driver_sps30/
Firmware Output
main(): This is RIOT! (Version: 2020.07-devel-200-gea488-Kconfig_sps30_tests)
CONFIG_SPS30_ERROR_RETRY=0
SPS30 test application
sps30_init: [I2C_ERROR]
sps30_read_article_code: [I2C_ERROR]
sps30_read_serial_number: [I2C_ERROR]
sps30_start_fan_clean: [I2C_ERROR]
Note : The sensor is not available for interfacing hence configurability of macros were only tested.
Issues/PRs references
#12888
@leandrolanzieri