drivers/slipdev : Expose Configurations to Kconfig#13954
Merged
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom Apr 29, 2020
Merged
drivers/slipdev : Expose Configurations to Kconfig#13954leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom
Conversation
9ff41a9 to
d094f35
Compare
71 tasks
Contributor
leandrolanzieri
left a comment
There was a problem hiding this comment.
Just a minor comment. Please address it and squash directly
2db769d to
099f426
Compare
Add CONFIG_ prefix to SLIPDEV_BUFSIZE
Expose configurations to Kconfig
099f426 to
e6924e5
Compare
leandrolanzieri
approved these changes
Apr 29, 2020
Contributor
leandrolanzieri
left a comment
There was a problem hiding this comment.
ACK! Thanks for the contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR exposes compile configurations in SLIPDEV Network driver to Kconfig.
Testing procedure
New folder (/tests/driver_slipdev) was added. New test file and Make file was introduced in tests/driver_slipdev/ for testing.
Firmware was tested on native.
Default State:
Firmware Output
RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.
main(): This is RIOT! (Version: 2020.07-devel-201-g2e015-Kconfig_slipdev_tests)
CONFIG_SLIPDEV_BUFSIZE=(2048U)
Usage with CFLAGS
/tests/driver_slipdev/Makefile
Firmware Output
RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.
main(): This is RIOT! (Version: 2020.07-devel-201-g2e015-Kconfig_slipdev_tests)
CONFIG_SLIPDEV_BUFSIZE=128
Usage with Kconfig
/tests/driver_slipdev/
Firmware Output
RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.
main(): This is RIOT! (Version: 2020.07-devel-201-g2e015-Kconfig_slipdev_tests)
CONFIG_SLIPDEV_BUFSIZE=4096
Issues/PRs references
#12888
@leandrolanzieri