drivers/rn2xx3 : Expose Configurations to Kconfig#13952
Merged
leandrolanzieri merged 3 commits intoRIOT-OS:masterfrom May 22, 2020
Merged
drivers/rn2xx3 : Expose Configurations to Kconfig#13952leandrolanzieri merged 3 commits intoRIOT-OS:masterfrom
leandrolanzieri merged 3 commits intoRIOT-OS:masterfrom
Conversation
71 tasks
Add CONFIG_ prefix to RN2XX3_DEFAULT_SLEEP
Expose configurations to Kconfig Co-Authored-By: Leandro Lanzieri <leandro.lanzieri@haw-hamburg.de>
Create new file for Kconfig Macro definitions Co-authored-by: Leandro Lanzieri <leandro.lanzieri@haw-hamburg.de>
leandrolanzieri
approved these changes
May 22, 2020
Contributor
leandrolanzieri
left a comment
There was a problem hiding this comment.
Looks good to me. Tested building and changing the sleep value, and it works fine. ACK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR exposes compile configurations in RN2XX3 Network Device driver to Kconfig.
Testing procedure
New macro was introduced in tests/driver_rn2xx3/main.c for testing.
Firmware was uploaded to FIT IoT Lab test bed.
Default State:
Firmware Output
main(): This is RIOT! (Version: 2020.07-devel-199-gd936bb-Kconfig_rn2xx3)
CONFIG_RN2XX3_DEFAULT_SLEEP=(5000U)
RN2XX3 device driver test
RN2XX3 initialization failed
Usage with CFLAGS
/tests/driver_rn2xx3/Makefile
Firmware Output
main(): This is RIOT! (Version: 2020.07-devel-199-gd936bb-Kconfig_rn2xx3)
CONFIG_RN2XX3_DEFAULT_SLEEP=7000
RN2XX3 device driver test
RN2XX3 initialization failed
Usage with Kconfig
/tests/driver_rn2xx3/
Firmware Output
main(): This is RIOT! (Version: 2020.07-devel-199-gd936bb-Kconfig_rn2xx3)
CONFIG_RN2XX3_DEFAULT_SLEEP=10000
RN2XX3 device driver test
RN2XX3 initialization failed
Note : The sensor is not available for interfacing hence configurability of macros were only tested.
Issues/PRs references
#12888
@leandrolanzieri