Skip to content

drivers/pn532 : Expose Configurations to Kconfig #13951

Merged
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom
akshaim:Kconfig_pn532
Apr 27, 2020
Merged

drivers/pn532 : Expose Configurations to Kconfig #13951
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom
akshaim:Kconfig_pn532

Conversation

@akshaim
Copy link
Copy Markdown
Member

@akshaim akshaim commented Apr 25, 2020 •
edited
Loading

Contribution description

This PR exposes compile configurations in PN532 Network Device driver to Kconfig.

Testing procedure

New macro was introduced in tests/driver_pn532/main.c for testing.

#define STR(x)   #x
#define SHOW_DEFINE(x) printf("%s=%s\n", #x, STR(x))

Firmware was uploaded to FIT IoT Lab test bed.

Default State:

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-198-gcf64d-Kconfig_pn532)
CONFIG_PN532_BUFFER_LEN=(64)
awake
ver 0.2
set sam 0

Usage with CFLAGS

/tests/driver_pn532/Makefile

CFLAGS += -DCONFIG_PN532_BUFFER_LEN=128

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-198-gcf64d-Kconfig_pn532)
CONFIG_PN532_BUFFER_LEN=128
awake
ver 0.2
set sam 0

Usage with Kconfig

/tests/driver_pn532/

make menuconfig

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-198-gcf64d-Kconfig_pn532)
CONFIG_PN532_BUFFER_LEN=256
awake
ver 0.2
set sam 0

Note : The sensor is not available for interfacing hence configurability of macros were only tested.

Issues/PRs references

#12888
@leandrolanzieri

akshaim added 2 commits April 25, 2020 22:33
@akshaim
drivers/pn532 : Add CONFIG_
53c988a 
ADD CONFIG_ prefix to PN532_BUFFER_LEN
@akshaim
drivers/pn532 : Expose to Kconfig
0277b0f 
Expose configurations to Kconfig
@leandrolanzieri leandrolanzieri added Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Apr 27, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Apr 27, 2020
@leandrolanzieri leandrolanzieri mentioned this pull request Apr 27, 2020
Open
71 tasks
leandrolanzieri
leandrolanzieri approved these changes Apr 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The parameter is configurable via Kconfig. ACK.

@leandrolanzieri leandrolanzieri added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Apr 27, 2020
@leandrolanzieri leandrolanzieri merged commit ca43957 into RIOT-OS:master Apr 27, 2020
@akshaim akshaim deleted the Kconfig_pn532 branch May 4, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees

No one assigned

Labels

Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2020.07

Development

Successfully merging this pull request may close these issues.

2 participants

@akshaim @leandrolanzieri