drivers/mma8x5x : Expose Configurations to Kconfig#13926
Merged
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom Apr 23, 2020
Merged
drivers/mma8x5x : Expose Configurations to Kconfig#13926leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom
Conversation
Add CONFIG_ Prefix for CONFIG_MMA8X5X_I2C_ADDRESS
e836ec9 to
f08bb0f
Compare
Expose Configurations to Kconfig
f08bb0f to
ec98054
Compare
leandrolanzieri
approved these changes
Apr 23, 2020
Contributor
leandrolanzieri
left a comment
There was a problem hiding this comment.
Looks good. The configuration macro is generated correctly. ACK.
71 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR exposes compile configurations in MMA8X5X Sensor Device driver to Kconfig.
Testing procedure
The firmware was uploaded to FIT/IoT-LAB Test Bed and following results were obtained.
New macro was introduced in main.c for testing.
Default State:
Firmware Output
main(): This is RIOT! (Version: 2020.07-devel-159-ge836e-Kconfig_mma8x5x)
CONFIG_MMA8X5X_I2C_ADDRESS=0x1D
MMA8652 accelerometer driver test application
Initializing MMA8652 accelerometer at I2C_DEV(0)... [Failed]
Usage with CFLAGS
/tests/driver_mma8x5x/Makefile
Firmware Output
main(): This is RIOT! (Version: 2020.07-devel-159-ge836e-Kconfig_mma8x5x)
CONFIG_MMA8X5X_I2C_ADDRESS=0x1C
MMA8652 accelerometer driver test application
Initializing MMA8652 accelerometer at I2C_DEV(0)... [Failed]
Usage with Kconfig
/tests/driver_mma8x5x/
Firmware Output
main(): This is RIOT! (Version: 2020.07-devel-159-ge836e-Kconfig_mma8x5x)
CONFIG_MMA8X5X_I2C_ADDRESS=0x1C
MMA8652 accelerometer driver test application
Initializing MMA8652 accelerometer at I2C_DEV(0)... [Failed]
Note : The network device is not available fro interfacing hence configurability of macros were only tested.
Issues/PRs references
#12888
@leandrolanzieri