drivers/mag3110 : Expose Configurations to Kconfig#13915
Merged
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom Apr 23, 2020
Merged
drivers/mag3110 : Expose Configurations to Kconfig#13915leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom
Conversation
71 tasks
4905ffc to
28a8d74
Compare
Contributor
leandrolanzieri
left a comment
There was a problem hiding this comment.
Looks good, please squash
Add CONFIG_ Prefix for MAG3110_I2C_ADDRESS
Expose Configurations to Kconfig Co-Authored-By: Leandro Lanzieri <leandro.lanzieri@haw-hamburg.de>
28a8d74 to
fc3ff2a
Compare
Member
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR exposes compile configurations in MAG3110 Sensor Device driver to Kconfig.
Testing procedure
The firmware was uploaded to FIT/IoT-LAB Test Bed and following results were obtained.
Default State:
Firmware Output
main(): This is RIOT! (Version: 2020.07-devel-147-g8a1d9-Kconfig_mag3110)
CONFIG_MAG3110_I2C_ADDRESS=0x0E
MAG3110 magnetometer driver test application
Initializing MAG3110 magnetometer at I2C_0... mag3110_init: invalid WHO_AM_I value (0x20)!
[FAILED]
Usage with CFLAGS
/tests/driver_mag3110/Makefile
Firmware Output
main(): This is RIOT! (Version: 2020.07-devel-147-g8a1d9-Kconfig_mag3110)
CONFIG_MAG3110_I2C_ADDRESS=0x0F
MAG3110 magnetometer driver test application
Initializing MAG3110 magnetometer at I2C_0... mag3110_init: invalid WHO_AM_I value (0x20)!
[FAILED]
Usage with Kconfig
/tests/mag3110/
Firmware Output
main(): This is RIOT! (Version: 2020.07-devel-147-g8a1d9-Kconfig_mag3110)
CONFIG_MAG3110_I2C_ADDRESS=0x0f
MAG3110 magnetometer driver test application
Initializing MAG3110 magnetometer at I2C_0... mag3110_init: invalid WHO_AM_I value (0x20)!
[FAILED]
Note : The network device is not available fro interfacing hence configurability of macros were only tested.
Issues/PRs references
#12888
@leandrolanzieri