Skip to content

drivers/fxos8700 : Expose Configurations to Kconfig#13914

Merged
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom
akshaim:Kconfig_fxos8700
Apr 29, 2020
Merged

drivers/fxos8700 : Expose Configurations to Kconfig#13914
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom
akshaim:Kconfig_fxos8700

Conversation

@akshaim
Copy link
Copy Markdown
Member

@akshaim akshaim commented Apr 21, 2020

Contribution description

This PR exposes compile configurations in fxos8700 sensor driver to Kconfig.

Testing procedure

The firmware was uploaded to FIT/IoT-LAB Test Bed and following results were obtained.

New macro was introduced in main.c for testing.

#define STR(x)   #x
#define SHOW_DEFINE(x) printf("%s=%s\n", #x, STR(x))

Default State:

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-119-g0c64e-Kconfig_fxos8700)
CONFIG_FXOS8700_USE_ACC_RAW_VALUES=(0)
FXOS8700 driver test application

Usage with CFLAGS

/tests/driver_fxos8700/Makefile

CFLAGS += -DCONFIG_FXOS8700_USE_ACC_RAW_VALUES=1

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-119-g0c64e-Kconfig_fxos8700)
CONFIG_FXOS8700_USE_ACC_RAW_VALUES=1
FXOS8700 driver test application

Usage with Kconfig

/tests/driver_fxos8700/

make menuconfig

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-119-g0c64e-Kconfig_fxos8700)
CONFIG_FXOS8700_USE_ACC_RAW_VALUES=1
FXOS8700 driver test application

Note : The sensor is not available hence configurability of macros were only tested.

Issues/PRs references

#12888
@leandrolanzieri

leandrolanzieri
leandrolanzieri reviewed Apr 21, 2020
View reviewed changes
@leandrolanzieri leandrolanzieri mentioned this pull request Apr 21, 2020
Open
71 tasks
@leandrolanzieri leandrolanzieri added Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Apr 21, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Apr 21, 2020
leandrolanzieri
leandrolanzieri reviewed Apr 23, 2020
View reviewed changes
leandrolanzieri
leandrolanzieri reviewed Apr 28, 2020
View reviewed changes
@leandrolanzieri
Copy link
Copy Markdown
Contributor

leandrolanzieri commented Apr 28, 2020

Please squash

@akshaim
Copy link
Copy Markdown
Member Author

akshaim commented Apr 28, 2020

Please squash

Done. Thanks for the comments.

@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 28, 2020
@leandrolanzieri
Copy link
Copy Markdown
Contributor

leandrolanzieri commented Apr 28, 2020

Just merge d64e7e8 and 428c043

@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Apr 28, 2020
@akshaim
Copy link
Copy Markdown
Member Author

akshaim commented Apr 29, 2020

Just merge d64e7e8 and 428c043

Done.

@leandrolanzieri
Copy link
Copy Markdown
Contributor

leandrolanzieri commented Apr 29, 2020

@akshaim please check the whitespace error that the CI points out

akshaim and others added 2 commits April 29, 2020 14:32
@akshaim @leandrolanzieri
drivers/fxos8700 : Add CONFIG_
e5fe525 
Add CONFIG_ Prefix for FXOS8700_USE_ACC_RAW_VALUES and model
it as a bool

Co-Authored-By: Leandro Lanzieri <leandro.lanzieri@haw-hamburg.de>
@akshaim
drivers/fxos8700 : Expose to Kconfig
0bc7952 
Expose Configurations to Kconfig
@akshaim
Copy link
Copy Markdown
Member Author

akshaim commented Apr 29, 2020

@akshaim please check the whitespace error that the CI points out

Done. Thanks

leandrolanzieri
leandrolanzieri approved these changes Apr 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@leandrolanzieri leandrolanzieri merged commit c8fa7f0 into RIOT-OS:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees

No one assigned

Labels

Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2020.07

Development

Successfully merging this pull request may close these issues.

2 participants

@akshaim @leandrolanzieri