drivers/at86rf215 : Expose Configurations to Kconfig#13885
Merged
leandrolanzieri merged 3 commits intoRIOT-OS:masterfrom Apr 22, 2020
Merged
drivers/at86rf215 : Expose Configurations to Kconfig#13885leandrolanzieri merged 3 commits intoRIOT-OS:masterfrom
leandrolanzieri merged 3 commits intoRIOT-OS:masterfrom
Conversation
benpicco
reviewed
Apr 17, 2020
leandrolanzieri
requested changes
Apr 17, 2020
71 tasks
benpicco
reviewed
Apr 17, 2020
benpicco
reviewed
Apr 17, 2020
benpicco
approved these changes
Apr 17, 2020
Contributor
|
Please squash and rebase |
Add Add CONFIG_ Prefix for AT86RF215_USE_CLOCK_OUTPUT and model it as a bool Co-Authored-By: Leandro Lanzieri <leandro.lanzieri@haw-hamburg.de>
Add CONFIG_ Prefix for configuring AT86RF215_TRIM_VAL
Expose Configurations to Kconfig Co-Authored-By: benpicco <benpicco@googlemail.com> Co-Authored-By: Leandro Lanzieri <leandro.lanzieri@haw-hamburg.de>
a2eccf7 to
7b2591e
Compare
Member
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR exposes compile configurations in at86rf215 network device driver to Kconfig. The following macro was define to print the macros.
#define STR(x) #x
#define SHOW_DEFINE(x) printf("%s=%s\n", #x, STR(x))
Testing procedure
The firmware was uploaded to FIT/IoT-LAB Test Bed and following results were obtained.
Default State:
Firmware Output
gnrc_netif: netdev init failed: -19
gnrc_netif: netdev init failed: -134
main(): This is RIOT! (Version: 2020.07-devel-82-g1d30-Kconfig_at86rf215)
CONFIG_AT86RF215_USE_CLOCK_OUTPUT=0
CONFIG_AT86RF215_TRIM_VAL=CONFIG_AT86RF215_TRIM_VAL
Usage with CFLAGS
/tests/driver_at86rf215/Makefile
Firmware Output
gnrc_netif: netdev init failed: -19
gnrc_netif: netdev init failed: -134
main(): This is RIOT! (Version: 2020.07-devel-82-g1d30-Kconfig_at86rf215)
CONFIG_AT86RF215_USE_CLOCK_OUTPUT=1
CONFIG_AT86RF215_TRIM_VAL=5
Usage with Kconfig
/tests/at86rf215/
Firmware Output
gnrc_netif: netdev init failed: -19
gnrc_netif: netdev init failed: -134
main(): This is RIOT! (Version: 2020.07-devel-82-g1d30-Kconfig_at86rf215)
CONFIG_AT86RF215_USE_CLOCK_OUTPUT=1
CONFIG_AT86RF215_TRIM_VAL=15
Note : The sensor is not available hence configurability of macros were only tested.
Issues/PRs references
#12888
@leandrolanzieri