Skip to content

drivers/ads101x : Expose Configurations to Kconfig #13881

Merged
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom
akshaim:kconfig_ads101x
Apr 17, 2020
Merged

drivers/ads101x : Expose Configurations to Kconfig #13881
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom
akshaim:kconfig_ads101x

Conversation

@akshaim
Copy link
Copy Markdown
Member

@akshaim akshaim commented Apr 16, 2020

Contribution description

This PR exposes compile configurations in ADS101X sensor driver to Kconfig.

Testing procedure

The firmware was uploaded to FIT/IoT-LAB Test Bed and following results were obtained.

Default State:

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-55-g1a2b1-kconfig_ads101x)
CONFIG_ADS101X_I2C_ADDRESS=(0x48)
ADS101X analog to digital driver test application

Initializing ADS101x analog to digital at I2C_DEV(0)... [Failed]

Usage with CFLAGS

/tests/driver_ads101x/Makefile

CFLAGS += -DCONFIG_ADS101X_I2C_ADDRESS=0x49

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-55-g1a2b1-kconfig_ads101x)
CONFIG_ADS101X_I2C_ADDRESS=0x49
ADS101X analog to digital driver test application

Initializing ADS101x analog to digital at I2C_DEV(0)... [Failed]

Usage with Kconfig

/tests/ads101x/

make menuconfig

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-55-g1a2b1-kconfig_ads101x)
CONFIG_ADS101X_I2C_ADDRESS=0x51
ADS101X analog to digital driver test application

Initializing ADS101x analog to digital at I2C_DEV(0)... [Failed]

Note : The sensor is not available hence configurability of macros were only tested.

Issues/PRs references

#12888
@leandrolanzieri

@leandrolanzieri leandrolanzieri added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: Kconfig Area: Kconfig integration Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Apr 16, 2020
@leandrolanzieri
Copy link
Copy Markdown
Contributor

Please rebase

@leandrolanzieri leandrolanzieri removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 16, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Apr 16, 2020
@akshaim
Copy link
Copy Markdown
Member Author

akshaim commented Apr 17, 2020

Please rebase

Done.

Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits.

@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines labels Apr 17, 2020
akshaim and others added 2 commits April 17, 2020 16:43
Add CONFIG_ Prefix for configuring the Compile time macros
Expose Configurations to Kconfig

Co-Authored-By: Leandro Lanzieri <leandro.lanzieri@haw-hamburg.de>
@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 17, 2020
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@leandrolanzieri leandrolanzieri merged commit 2f75c60 into RIOT-OS:master Apr 17, 2020
@akshaim akshaim deleted the kconfig_ads101x branch April 17, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants