drivers/hdc1000 : Expose Configurations to Kconfig#13870
Merged
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom Apr 16, 2020
Merged
drivers/hdc1000 : Expose Configurations to Kconfig#13870leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom
Conversation
leandrolanzieri
requested changes
Apr 15, 2020
71 tasks
Contributor
|
Changes look good. Please squash @akshaim |
Add CONFIG_ Prefix for configuring the Compile time macros
94bf03b to
a6dc80a
Compare
Member
Author
Done. Thanks for the review |
Contributor
|
@akshaim please fix the error pointed out by Travis and squash directly |
Expose Configurations to Kconfig Co-Authored-By: Leandro Lanzieri <leandro.lanzieri@haw-hamburg.de>
a6dc80a to
79de251
Compare
Member
Author
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR exposes compile configurations in HDC1000 sensor driver to Kconfig.
Testing procedure
The firmware was uploaded to FIT/IoT-LAB Test Bed and following results were obtained.
Default State:
main(): This is RIOT! (Version: 2020.07-devel-46-g4e42a-tests_hdc1000)
CONFIG_HDC1000_CONVERSION_TIME=(26000)
CONFIG_HDC1000_I2C_ADDRESS=(0x43)
HDC1000 Temperature and Humidity Sensor driver test application
Initializing HDC1000 sensor at I2C_DEV(0)... [Failed]
Usage with CFLAGS
/tests/driver_hdc1000/Makefile
Output
main(): This is RIOT! (Version: 2020.07-devel-46-g4e42a-tests_hdc1000)
CONFIG_HDC1000_CONVERSION_TIME=14000
CONFIG_HDC1000_I2C_ADDRESS=0x42
HDC1000 Temperature and Humidity Sensor driver test application
Initializing HDC1000 sensor at I2C_DEV(0)... [Failed]
Usage with Kconfig
/tests/driver_hdc1000/
main(): This is RIOT! (Version: 2020.07-devel-46-g4e42a-tests_hdc1000)
CONFIG_HDC1000_CONVERSION_TIME=13000
CONFIG_HDC1000_I2C_ADDRESS=0x40
HDC1000 Temperature and Humidity Sensor driver test application
Initializing HDC1000 sensor at I2C_DEV(0)... [Failed]
Note : The sensor is not available hence configurability of macros were only tested.
Issues/PRs references
#12888
@leandrolanzieri