Skip to content

Backport/2020.01/fix13179 Revert "boards/nucleo-f767zi: add correct flash bank openocd config"#13513

Closed
kfessel wants to merge 2 commits intoRIOT-OS:2020.01-branchfrom
kfessel:backport/2020.01/fix13179
Closed

Backport/2020.01/fix13179 Revert "boards/nucleo-f767zi: add correct flash bank openocd config"#13513
kfessel wants to merge 2 commits intoRIOT-OS:2020.01-branchfrom
kfessel:backport/2020.01/fix13179

Conversation

@kfessel
Copy link
Copy Markdown
Contributor

@kfessel kfessel commented Feb 28, 2020

same as #13470 but fixing the Backport of #13179 , which is #13219

PR #13179 and is #13219 introduced debugging problems for boards/nucleo-f767zi, unable to set breakpoints with current versions of openocd (its possible with old versions such as the one provided with ubuntu since it is ignoring gdb (hard or soft breakpoint))

This was referenced Feb 28, 2020
Merged
Closed
@kfessel kfessel changed the title Backport/2020.01/fix13179 Backport/2020.01/fix13179 Revert "boards/nucleo-f767zi: add correct flash bank openocd config" Feb 28, 2020
@fjmolinas
Copy link
Copy Markdown
Contributor

fjmolinas commented Mar 2, 2020

@kfessel do you mind using the backport script for this?

@kfessel
Copy link
Copy Markdown
Contributor Author

kfessel commented Mar 2, 2020

I did use the Backportscript but it did not create an PR, so I did. maybe i should retry ( there might be something missing for the github token)

@kfessel
Copy link
Copy Markdown
Contributor Author

kfessel commented Mar 2, 2020 •
edited
Loading

Something is not working even though the token has public repo (i even generated a whole new token):

Error creating the new pr: "Validation Failed". Is "Public Repo" access enabled for the token
Traceback (most recent call last):
File "./dist/tools/backport_pr/backport_pr.py", line 258, in
main()
File "./dist/tools/backport_pr/backport_pr.py", line 239, in main
pr_number = new_pr['number']
KeyError: 'number'

token

@fjmolinas
Copy link
Copy Markdown
Contributor

fjmolinas commented Mar 2, 2020

Something is not working even though the token has public repo (i even generated a whole new token):

Is the token stored at ~/.riotgithubtoken?

@fjmolinas
Copy link
Copy Markdown
Contributor

fjmolinas commented Mar 2, 2020

Is the token stored at ~/.riotgithubtoken?

If you still have issues, I'll just give the PR the usual backport look ;)

@kfessel kfessel closed this Mar 2, 2020
@kfessel kfessel deleted the backport/2020.01/fix13179 branch March 2, 2020 16:40
@kfessel
Copy link
Copy Markdown
Contributor Author

kfessel commented Mar 2, 2020 •
edited
Loading

i got it: #13531

  • i needed to delete the local branch that the script created and the remote one

@kfessel kfessel mentioned this pull request Mar 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kfessel @fjmolinas