Skip to content

usbus/cdc/acm: Expose configurations to Kconfig#13375

Merged
bergzand merged 3 commits intoRIOT-OS:masterfrom
leandrolanzieri:pr/kconfig_migrate/sys/usbus_cdc
Apr 7, 2020
Merged

usbus/cdc/acm: Expose configurations to Kconfig#13375
bergzand merged 3 commits intoRIOT-OS:masterfrom
leandrolanzieri:pr/kconfig_migrate/sys/usbus_cdc

Conversation

@leandrolanzieri
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri commented Feb 13, 2020 •
edited
Loading

Contribution description

This moves compile-time configurations for the USBUS CDC ACM module to the CONFIG_ namespace and exposes them to Kconfig.

Testing procedure

tests/usbus_cdc_acm_stdio should work and you should be able to configure options via Kconfig.

Issues/PRs references

Depends on #13374
Part of #12888

@leandrolanzieri leandrolanzieri added Type: new feature The issue requests / The PR implemements a new feature for RIOT State: waiting for other PR State: The PR requires another PR to be merged first Area: Kconfig Area: Kconfig integration labels Feb 13, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Feb 13, 2020
@leandrolanzieri leandrolanzieri mentioned this pull request Feb 13, 2020
Open
71 tasks
@bergzand
Copy link
Copy Markdown
Member

bergzand commented Apr 3, 2020 •
edited
Loading

The config options look good to me. I've played around with the configuration options and things look fine. I've asked @cgundogan to give this a final test.

Wrong PR

@leandrolanzieri leandrolanzieri force-pushed the pr/kconfig_migrate/sys/usbus_cdc branch from 0190b55 to 16dbb96 Compare April 6, 2020 06:52
@leandrolanzieri leandrolanzieri removed the State: waiting for other PR State: The PR requires another PR to be merged first label Apr 6, 2020
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Apr 6, 2020

#13374 was merged, this PR does not have dependencies now.

@bergzand bergzand self-assigned this Apr 7, 2020
bergzand
bergzand requested changes Apr 7, 2020
View reviewed changes
bergzand
bergzand reviewed Apr 7, 2020
View reviewed changes
@bergzand
Copy link
Copy Markdown
Member

bergzand commented Apr 7, 2020

Please squash!

@leandrolanzieri leandrolanzieri force-pushed the pr/kconfig_migrate/sys/usbus_cdc branch from fb364ed to 934bede Compare April 7, 2020 12:36
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Apr 7, 2020

@bergzand squashed!

@bergzand bergzand added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 7, 2020
@bergzand bergzand merged commit c81c8ed into RIOT-OS:master Apr 7, 2020
@leandrolanzieri leandrolanzieri deleted the pr/kconfig_migrate/sys/usbus_cdc branch April 7, 2020 13:05
@leandrolanzieri
Copy link
Copy Markdown
Contributor Author

leandrolanzieri commented Apr 7, 2020

@bergzand thanks for the review!

@leandrolanzieri leandrolanzieri mentioned this pull request Apr 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergzand bergzand bergzand approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@dylad dylad Awaiting requested review from dylad dylad is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees

@bergzand bergzand

Labels

Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2020.04

Development

Successfully merging this pull request may close these issues.

2 participants

@leandrolanzieri @bergzand