Skip to content

tinydtls: remove TINYDTLS_LOG and cleanup#13290

Merged
smlng merged 3 commits intoRIOT-OS:masterfrom
pokgak:pr/tinydtls/cleanup
Feb 6, 2020
Merged

tinydtls: remove TINYDTLS_LOG and cleanup#13290
smlng merged 3 commits intoRIOT-OS:masterfrom
pokgak:pr/tinydtls/cleanup

Conversation

@pokgak
Copy link
Copy Markdown
Contributor

@pokgak pokgak commented Feb 5, 2020

Contribution description

TINYDTLS_LOG currently just sets another flag TINYDTLS_LOG_LVL. This PR removes TINYDTLS_LOG from tinydtls Makefiles and its usage in the dtls-echo and dtls-sock example application. Applications that want to set the log level of tinydtls manually can still use TINYDTLS_LOG_LVL directly. This simplifies the logic in tinydtls Makefile.include.

This PR also removes the redundant check for tinydtls in the Makefile.include.

Testing procedure

Check the dtls-echo and the dtls-sock example still compiles and the debug log is enabled when DTLS_DEBUG is added to CFLAGS

Aiman Ismail added 3 commits February 5, 2020 06:58
examples/dtls-echo: remove TINYDTLS_LOG and use DTLS_DEBUG
bbb551e
examples/dtls-sock: remove TINYDTLS_LOG
24b42d1
pkg/tinydtls: cleanup Makefile.include
5391e50 
- Removes `TINYDTLS_LOG` because it is redundant with `TINYDTLS_LOG_LVL`
- Remove check for using tinydtls module because the Makefile will only
be included if the tinydtls module is used
@pokgak pokgak requested a review from smlng February 5, 2020 06:15
@pokgak pokgak mentioned this pull request Feb 5, 2020
Merged
smlng
smlng approved these changes Feb 5, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks straight forward, lets see what CI says.

@smlng smlng added Area: pkg Area: External package ports Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 5, 2020
@pokgak
Copy link
Copy Markdown
Contributor Author

pokgak commented Feb 5, 2020

All green!

@smlng smlng merged commit 24f6b39 into RIOT-OS:master Feb 6, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Feb 20, 2020
@leandrolanzieri leandrolanzieri added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@smlng smlng smlng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2020.04

Development

Successfully merging this pull request may close these issues.

3 participants

@pokgak @smlng @leandrolanzieri