gnrc_ipv6_ext_opt: initial import#13275
Merged
benpicco merged 3 commits intoRIOT-OS:masterfrom May 20, 2020
Merged
Conversation
Member
Author
|
Forgot to commit the most important part... The actual module 😅 |
aabadie
reviewed
Mar 5, 2020
Contributor
aabadie
left a comment
There was a problem hiding this comment.
Found some minor things in this PR but haven't look in detail at the compliance of the implementation with the RFC.
Member
Author
|
Addressed comments |
benpicco
reviewed
May 10, 2020
benpicco
reviewed
May 12, 2020
benpicco
approved these changes
May 19, 2020
Contributor
benpicco
left a comment
There was a problem hiding this comment.
Please squash!
Code looks good, there are working tests and this is self-contained without affecting anything else - ACK.
Member
Author
|
Squashed. |
0d7eb79 to
564eb78
Compare
Contributor
|
flake8 is nitpicking the Python code - just squash directly. |
This provides header parsing for IPv6 hop-by-hop and destination options according to [RFC 8200]. [RFC 8200]: https://tools.ietf.org/html/rfc8200#section-4.2
564eb78 to
f6bd070
Compare
Member
Author
|
Fixed and squashed all static test failures (not just |
Contributor
|
What's left after this to implement non-storing mode? |
Member
Author
|
The hop-by-hop option needs to be implemented still. |
Member
Author
|
See https://github.com/miri64/RIOT/tree/gnrc_rpl_opt/feat/initial for my initial work on that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This provides header parsing for IPv6 hop-by-hop and destination options according to RFC 8200.
Testing procedure
I provided a test application using
scapy:make -C tests/gnrc_ipv6_ext_opt/ flash sudo BOARD=samr21-xpro make -C tests/gnrc_ipv6_ext_opt/ testIssues/PRs references
First step for a new adaptation for #7231