tests/conn_can: fix build error on native#13270
Merged
kaspar030 merged 4 commits intoRIOT-OS:masterfrom Feb 24, 2020
Merged
Conversation
kaspar030
requested changes
Feb 3, 2020
28a060c to
0250851
Compare
98aa257 to
940ded3
Compare
940ded3 to
ae947d5
Compare
Member
Author
|
Any update on this @kaspar030? |
benpicco
reviewed
Feb 20, 2020
vincent-d
reviewed
Feb 20, 2020
Member
|
ping @kaspar030 |
Member
Author
|
@kaspar030 Still want something changed? :) |
kaspar030
approved these changes
Feb 24, 2020
Contributor
|
Nope, all good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
When building tests/conn_can for native, it would fail because of unsatisfied feature requirements:
Adding an extra check for BOARD=native solves this problem.Remove these feature requirements all together, since they are not needed here (see conversation below).
update 7/02:
Testing procedure